ara0n / pyscandl Goto Github PK

Describe the bug
When a file name has the character "|" on windows, it causes the program to crash with an OSError and a TypeError.

To Reproduce
Steps to reproduce the behavior:

1. Download the sauce 321123 with the nhentai fetcher
2. See error

Expected behavior
The program crashes with 2 errors : an OSError and a TypeError

Screenshots

Desktop (please complete the following information):

• OS: Windows 10

The old api for mangadex is down, a switch to v2 is needed.
Doc for it is here: https://api.mangadex.org/v2/

To be able to be called as python -m pyscandl

Ce serait cool si le programme pouvait gérér le fait que l'utilisateur spécifie un chapitre de début, et un chapitre de fin

par exemple (si on suppose -e comme flag de chapitre de fin)
python3 main.py -l <lien du manga> -f <nom du fetcher> -c 25 -e 37
au lieu de
python3 main.py -l <lien du manga> -f <nom du fetcher> -c 25 -n 12

If it would be possible for Naver Webtoons or Daum Webtoons to be added to supported websites for download.

The database is always stored in .local/share/ wheras it should only be stored there if the environment variable XDG_DATA_HOME isn't set, if said variable is set, it should be stored there instead

ArchLinux Wiki for reference

Describe the bug
on this chapter: https://fanfox.net/manga/survival_story_of_a_sword_king_in_a_fantasy_world/c052/1.html
the fetcher doesn't take the images correctly, resulting in a crash

To Reproduce
Steps to reproduce the behavior:
run pyscandl manual -f fanfox -l https://fanfox.net/manga/survival_story_of_a_sword_king_in_a_fantasy_world/ -c 52 -t -p

Expected behavior
the image argument will contain some html gibberish

Desktop (please complete the following information):

• OS: Debian testing

Describe the bug
There is a typo in the message that informs about the db migration

Warning: the current db will be replaced wywith a new system in the next major release (3.0.0). Please do not forget the migration at that time

Describe the solution you'd like
When you list the mangas it would be great to see which fetcher is associated with each manga.

Have the user be able to specify a default download folder that is not the current directory (maybe through a config file in $XDG_CONFIG_HOME / %appdata%) and/or through a command line option

Ce serait cool si le programme pouvait, lorsque que l'option -l est utilisée, détecter automatiquement le fetcher aproprié

Describe the bug
If the database is empty or doesn't exists, the GUI fails to load.

To Reproduce
Steps to reproduce the behavior:

• Have an empty database (or no database at all)
• Try to launch the GUI
• See it fail

Expected behavior
The GUI should be able to launch despite a empty or non-existant database

Version Info:

• OS: Garuda Linux (Arch based), KDE Plasma 5.21
• Version: 3.0.0-b2
• Installed via pip

The fanfox fetcher uses pexpect.spawn() which isn't available on windows, thus rendering the use of the Fanfox fetcher impossible