appupgrade-dev / app-upgrade-react-native-sdk Goto Github PK

Hello, everytime i want to create an upgrade i get confused about which version to enter. Can you please make it more clear, that the version you create is the one that you want to upgrade?

It seems like you got confused yourself when creating the documentation, because in the text you say to write 1.0.0 if you want to upgrade users to 1.0.1, however in the screenshot you have created the version as 1.0.1

Please can you add Typescript support?

Hi,

Really liking the service and library so far.

I have a few improvements to suggest:

• The try/catch & log on line 50 of api.js is not very useful to the caller of the function.
  • It feels like as the caller, I cannot handle the error and decide what to do. I think you should just throw the error. Or at least return false.
  • There are also logs that we may not even want to be logged in our app (we have a custom logger). So Ideally, this library would not log anything, but would either return some success object or error. Which we can handle and log as appropriate.
• You guys are using axiosRetry. I would add the retry attempts as a parameter so we can control this. i.e if we only wanted to check when the app first opens.
• Typescript support