apps-360 / site-search-360-react Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 1.0 339 KB

Site Search 360 component for React.

Home Page: https://sitesearch360.com/

License: Apache License 2.0

JavaScript 100.00%

react search sitesearch sitesearch360

site-search-360-react's People

Contributors

Watchers

Forkers

jmaza

site-search-360-react's Issues

Two search boxes on one page in Gatsby apps don't work correctly

Placing two search boxes on one page in a Gatsby app don't work correctly. I did a minimal bug reproduction and propose a solution.

See: https://github.com/don-esteban/for-jaro

TL;TR

Missing componentWillUnmount lifecycle method

componentWillUnmount() {
	const ss360Script = document.getElementById('ss360-script')
	if (ss360Script) {
		ss360Script.remove()
		delete window.initializeSs360
	}
}

Can't deploy [email protected] on Netlify/Gatsby

Locally, everything works as expected. I can build/run our production site locally without issues.

I can even deploy (to Netlify) the test-app https://github.com/don-esteban/for-jaro sucessfully.

But deploying the production site to Netlify fails.

Deployment works with this line in package.json:

...
"site-search-360-react": "^0.2.3",
...

Changing to 0.3.1 results in deployment errors. No other files touched!

...
"site-search-360-react": "^0.3.1",
...

...
11:35:13 AM: success run queries in workers - 286.927s - 1246/1246 4.34/s
11:35:36 AM: success Running gatsby-plugin-sharp.IMAGE_PROCESSING jobs - 362.157s - 273/273 0.75/s
11:35:36 AM: error UNHANDLED EXCEPTION write EPIPE
11:35:36 AM: 
11:35:36 AM: 
11:35:36 AM:   Error: write EPIPE
11:35:36 AM:   
11:35:36 AM:   - child_process.js:841 ChildProcess.target._send
11:35:36 AM:     internal/child_process.js:841:20
11:35:36 AM:   
11:35:36 AM:   - child_process.js:712 ChildProcess.target.send
11:35:36 AM:     internal/child_process.js:712:19
11:35:36 AM:   
11:35:36 AM:   - index.js:298 WorkerPool.sendMessage
11:35:36 AM:     [repo]/[gatsby-worker]/dist/index.js:298:19
11:35:36 AM:   
11:35:36 AM:   - worker-messaging.ts:22 
11:35:36 AM:     [repo]/[gatsby]/src/utils/jobs/worker-messaging.ts:22:22
11:35:36 AM:   
11:35:36 AM: 
11:35:36 AM: not finished Merge worker state - 0.379s
11:35:37 AM: 
11:35:37 AM: ────────────────────────────────────────────────────────────────
11:35:37 AM:   "build.command" failed                                        
11:35:37 AM: ────────────────────────────────────────────────────────────────
11:35:37 AM: 
11:35:37 AM:   Error message
11:35:37 AM:   Command failed with exit code 1: gatsby build (https://ntl.fyi/exit-code-1)
11:35:37 AM: 
11:35:37 AM:   Error location
11:35:37 AM:   In Build command from Netlify app:
11:35:37 AM:   gatsby build
11:35:37 AM: Creating deploy upload records
11:35:37 AM: 
11:35:37 AM:   Resolved config
11:35:37 AM:   build:
11:35:37 AM:     command: gatsby build
11:35:37 AM:     commandOrigin: ui
11:35:37 AM: Failed during stage 'building site': Build script returned non-zero exit code: 2 (https://ntl.fyi/exit-code-2)
...

package.json from the test app which deploys correctly

{
  "name": "my-gatsby-site",
  "version": "1.0.0",
  "private": true,
  "description": "my-gatsby-site",
  "author": "donesteban",
  "keywords": [
    "gatsby"
  ],
  "scripts": {
    "develop": "gatsby develop",
    "start": "gatsby develop",
    "build": "gatsby build",
    "serve": "gatsby serve",
    "clean": "gatsby clean"
  },
  "dependencies": {
    "gatsby": "^4.11.2",
    "react": "^17.0.1",
    "react-dom": "^17.0.1",
    "site-search-360-react": "^0.3.1"
  }
}

package.json from production app with deployment issues.

{
  "name": "software-express",
  "version": "4.2.0",
  "private": true,
  "description": "New layout system including startpage, topnav and page layouts",
  "author": "Don Esteban",
  "keywords": [
    "Software-Express"
  ],
  "scripts": {
    "dev": "gatsby develop",
    "start": "gatsby develop",
    "build": "gatsby build",
    "serve": "gatsby serve",
    "clean": "gatsby clean",
    "cdev": "gatsby clean; gatsby develop",
    "cbuild": "gatsby clean; gatsby build; gatsby serve"
  },
  "dependencies": {
    "@fortawesome/fontawesome-svg-core": "^1.2.36",
    "@fortawesome/free-solid-svg-icons": "^5.15.4",
    "@fortawesome/react-fontawesome": "^0.1.16",
    "@mdx-js/mdx": "^1.6.22",
    "@mdx-js/react": "^1.6.22",
    "@tippyjs/react": "^4.2.6",
    "email-validator": "^2.0.4",
    "gatsby": "^4.11.2",
    "gatsby-image": "^3.11.0",
    "gatsby-plugin-fontawesome-css": "^1.2.0",
    "gatsby-plugin-image": "^2.9.1",
    "gatsby-plugin-manifest": "^4.6.0",
    "gatsby-plugin-mdx": "^3.5.2",
    "gatsby-plugin-react-helmet": "^5.6.0",
    "gatsby-plugin-root-import": "^2.0.8",
    "gatsby-plugin-sass": "^5.5.0",
    "gatsby-plugin-sharp": "^4.5.2",
    "gatsby-plugin-sitemap": "^5.6.0",
    "gatsby-remark-autolink-headers": "^5.5.0",
    "gatsby-remark-copy-linked-files": "^5.5.0",
    "gatsby-remark-images": "^6.5.2",
    "gatsby-remark-normalize-paths": "^1.1.0",
    "gatsby-remark-responsive-iframe": "^5.5.0",
    "gatsby-remark-smartypants": "^5.5.0",
    "gatsby-source-filesystem": "^4.5.2",
    "gatsby-transformer-sharp": "^4.6.0",
    "gatsby-transformer-yaml": "^4.6.0",
    "mailgun-js": "^0.22.0",
    "node-fetch": "^2.6.1",
    "normalize.css": "^8.0.1",
    "react": "^17.0.1",
    "react-dom": "^17.0.1",
    "react-google-recaptcha": "^2.1.0",
    "react-helmet": "^6.1.0",
    "react-slidedown": "^2.4.7",
    "sanitize-html": "^2.6.1",
    "sass": "^1.49.0",
    "site-search-360-react": "^0.3.1",
    "unslugify": "^1.0.2"
  },
  "devDependencies": {
    "xlsx": "^0.17.5"
  }
}

I will cross post the issue to Netlify community.

Summary:

Local builds work with both versions 0.2.3 and 0.3.1
Test site deploys with both versions 0.2.3 and 0.3.1
Production site deploys with 0.2.3
Production site deployment fails with 0.3.1

site-search-360-react loads multiple times in Gatsby apps. Missing cleanup code?

Visit https://www.software-express.de/ and open Developer Tools

Now visit other page. Each page appends new loaders/themes.

Search Input appears two times

Issue: See attached screenshot

Site developed with Gatsby/React

Steps to reproduce:

Visit https://www.software-express.de/
Put some text in search input (upper right) and search
The result list contains the search input. That's correct.
Close the search result box
Visit another page
Perform a search again
The result list contains two search input fields now.

Thanks for Your support

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.