[SR-566] NSTask should forward a valid environment about swift-llbuild HOT 10 CLOSED

cc: @ddunbar

from swift-llbuild.

I haven't tried the docker test, but I tried this locally with your launch.swift and it works.

I suspect the problem you are hitting is related to the opening of the database. Will swift-build-tool have permissions to open .atllbuild/build.db?

from swift-llbuild.

Oh, actually that wouldn't explain why the same swift-build-tool invocation works inside the container. I verified I can repro w/ your docker container, investigating...

from swift-llbuild.

The problem is in your launch.swift, it has the wrong path to swift-build-tool, which is at /usr/local/bin, not /usr/bin.

If you fix that then you will get further (link still fails, probably because container doesn't have /usr/bin/clang++ I would guess?)

from swift-llbuild.

Updating path in reproduction case to /usr/local/bin.

clang++ is installed; and can link programs, otherwise this would never work. In reality this always works, except when NSTask spawned the process.

I don't know why the linker fails in this situation; that is the bug.

I have also tested if we can do NSTask->shell->sbt->linker, and the answer appears to be that any use of NSTask will break the linker. I have no theories for why that is so; the obvious candidates like environment variables (even if NSTask tries to break them) would be restored by the shell.

I am currently working around successfully with the POSIX "system(3)" call which is not affected by this issue.

from swift-llbuild.

In this case the problem is simply that NSTask isn't preserving the environment, so PATH isn't propagated to subprocess by NSTask.

Going NSTask -> shell works for me, but you have to remember to use "sh -l" to cause the environment to be reinitialized.

/cc @parkera

from swift-llbuild.

Thanks for tracking that down. Philippe, maybe you can take a look at this one?

from swift-llbuild.

Hmm looks like we don't do anything with the env but pass nil. Seems like an easy fix.

from swift-llbuild.

I pushed a change that should resolve this: apple/swift-corelibs-foundation@b3637a7

It would be good if this could be verified that the environment passing is correct. I did not get a chance yet to try it out with docker.

from swift-llbuild.

Needs verification

from swift-llbuild.