Code Monkey home page Code Monkey logo

Comments (5)

BenchR267 avatar BenchR267 commented on May 8, 2024

Sorry about that! The problem is that the targets have the same name in SwiftPM as they have in tools support core. There are multiple different solutions - each with a drawback. We'll discuss what to do next and revert the dependency from llbuild on tools support core for now: #555

from swift-llbuild.

swift-ci avatar swift-ci commented on May 8, 2024

Comment by Jim Dovey (JIRA)

No worries, I'm glad we were able to get it noticed & fixed quickly. It looks like the commit format for tools-support-core is ultimately to blame, because right now it's just the result of some copying of folders from SwiftPM's Source folder. Unless the Package format allows specifying a different names for the target vs. its source folder, it looks like there's going to be some more hurdles along the road.

Thanks for the quick turnaround.

from swift-llbuild.

BenchR267 avatar BenchR267 commented on May 8, 2024

That is actually possible. The Package.swift is not generated/copied, just the directories. So we could use different names for the targets and folders in the file system. The problem is that all imports in the source files would need to change to use the same target names as well :/
This will be solved when we remove the code from SwiftPM and it entirely lives in tools-support-core - we need SwiftPM to be able to declare a dependency on tsc first though.

from swift-llbuild.

BenchR267 avatar BenchR267 commented on May 8, 2024

We merged a temporary workaround of not declaring the new executable in llbuild here. A longer term solution will probably to define a local package for the executable which uses the llbuild package as a dependency.

from swift-llbuild.

BenchR267 avatar BenchR267 commented on May 8, 2024

Merged the local package in c67ef17

from swift-llbuild.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.