Comments (5)
Sorry about that! The problem is that the targets have the same name in SwiftPM as they have in tools support core. There are multiple different solutions - each with a drawback. We'll discuss what to do next and revert the dependency from llbuild on tools support core for now: #555
from swift-llbuild.
Comment by Jim Dovey (JIRA)
No worries, I'm glad we were able to get it noticed & fixed quickly. It looks like the commit format for tools-support-core is ultimately to blame, because right now it's just the result of some copying of folders from SwiftPM's Source folder. Unless the Package format allows specifying a different names for the target vs. its source folder, it looks like there's going to be some more hurdles along the road.
Thanks for the quick turnaround.
from swift-llbuild.
That is actually possible. The Package.swift is not generated/copied, just the directories. So we could use different names for the targets and folders in the file system. The problem is that all imports in the source files would need to change to use the same target names as well :/
This will be solved when we remove the code from SwiftPM and it entirely lives in tools-support-core - we need SwiftPM to be able to declare a dependency on tsc first though.
from swift-llbuild.
We merged a temporary workaround of not declaring the new executable in llbuild here. A longer term solution will probably to define a local package for the executable which uses the llbuild package as a dependency.
from swift-llbuild.
Merged the local package in c67ef17
from swift-llbuild.
Related Issues (20)
- [SR-13897] Can't build swift-llbuild2 with development Swift toolchain HOT 2
- [SR-13472] Create a Jenkins CI job to run the llbuild tests under ASan/TSan HOT 2
- [SR-13406] llbuild/unittests/Basic/LaneBasedExecutionQueueTest.cpp is not included for linux testing
- [SR-11730] [llbuild] Improve GraphViz as export format option to llbuild-analyze HOT 9
- [SR-11729] [llbuild] Add Chromium Tracing as export format option to llbuild-analyze
- [SR-9735] Ninja build to nonexistent subdirectories fails HOT 1
- [SR-8527] llbuild-ui doesn't load db with build.db produced by Xcode10b5
- [SR-8018] llbuild fails to build with SwiftPM because of the DEBUG define
- [SR-7447] llbuild/BuildSystem/BuildSystem.h:207:21: error: no type named 'vector' in namespace 'std' HOT 2
- [SR-7323] SPM can't handle spaces in path to Xcode HOT 2
- LLBuild tests suite failing on Ubuntu 22.04 with Python 3.10
- FB11020478 - Xcode 14 incremental builds are all serial HOT 6
- Overriding Xcode's llbuild with a custom llbuild binary HOT 1
- `llbuildSwift` fails to build with SwiftPM release configuration on Windows x86_64 HOT 5
- llbuild fails to build with _FORTIFY_SOURCE=2
- llbuild cannot build cmake projects ('|' operator not supported)
- [Xcode 15.1 Beta 2] Two tests failed due to "database is locked Possibly there are two concurrent builds running in the same filesystem location" HOT 4
- llbuild: 'sqlite3.h' file not found HOT 5
- Turning off whole-module optimization not (fully) supported?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swift-llbuild.