appgyver / ag-transaction Goto Github PK

Scenario:

• set up a successful transaction
• in the run block synchronously call abort before the transaction has had a chance to start

Observed outcome:

• abort fails: "Can't abort a transaction that did complete"

Expected outcome:

• abort succeeds
• transaction is never started

This is related to a larger inconsistency in how abortion chains are handled.

Related pull request: #3

Scenario:

• call abort on transaction
• abort short-circuits done as rejected
• abort rejects

Observed outcome:

• done is rejected despite possibly completing
• abort did not complete, but because done is rejected we cannot ever rollback either
• transaction appears to be in an inconsistent state

Solutions?

• Add latch that will prevent done from being completed during abortion attempt