Code Monkey home page Code Monkey logo

Comments (8)

FarmerChillax avatar FarmerChillax commented on June 1, 2024 1

I took a look at your changes, they look excellent. The only thing I could potentially see being slightly useful would be to add support for attaching a decorator to the Swagger UI OAuth redirect URL, since APIFlask wires in that route as well, but I have no personal use for it so I'm quite happy with the current proposed changeset.

It seems to me that this router only server the redirect, so I can't think of any scenarios where I need to add it,could you give me some prompt of specific scenarios?

I want support it by SWAGGER_UI_OAUTH_REDIRECT_DECORATORS

https://github.com/apiflask/apiflask/pull/508/files#diff-55322925cb31d71d2b3b276750c74f7761be9abf49ba290f80b955ceaeec927bR22

from apiflask.

greyli avatar greyli commented on June 1, 2024

Assigned to @FarmerChillax for CodeKitchen Song of Open Source Sprint 1

from apiflask.

FarmerChillax avatar FarmerChillax commented on June 1, 2024

If your program already has an authentication(such as HTTPBasicAuth),could you wanna reuse it?

from apiflask.

FarmerChillax avatar FarmerChillax commented on June 1, 2024

i wanna support this feature by #508
have any ideas for improvements?

from apiflask.

tsokalski avatar tsokalski commented on June 1, 2024

I’m currently traveling :) I’ll be home in a few days and can provide some feedback then.

Thanks for looking into this!

from apiflask.

tsokalski avatar tsokalski commented on June 1, 2024

If your program already has an authentication(such as HTTPBasicAuth),could you wanna reuse it?

The app's authentication is all custom-written, so I think the flexibility of applying an arbitrary decorator would be helpful for our use case.

i wanna support this feature by #508 have any ideas for improvements?

I took a look at your changes, they look excellent. The only thing I could potentially see being slightly useful would be to add support for attaching a decorator to the Swagger UI OAuth redirect URL, since APIFlask wires in that route as well, but I have no personal use for it so I'm quite happy with the current proposed changeset.

Thanks again!

from apiflask.

FarmerChillax avatar FarmerChillax commented on June 1, 2024

What do you think of this feature implementations? @greyli

from apiflask.

codekitchen-bot avatar codekitchen-bot commented on June 1, 2024

此问题已在 代码厨房 上被提及。那里可能有相关详细信息:

https://codekitchen.community/t/topic/1124/1

from apiflask.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.