addQueryFactorySubselect deprecated method for sObject (Related) about fflib-apex-common HOT 6 CLOSED

Not sure what it is your asking for here. A configured Query Factory is exposed from fflib_SObjectSelector via the newQueryFactory method, at this point you can call whatever methods you desire before calling toSOQL. Does this help?

from fflib-apex-common.

@afawcett , what I meant is in fflib_SObjectSelector addQueryFactorySubselect method is calling subSelectQuery(SObjectType related) method on line 330 of fflib_ObjectSelector.cls

Doesn't that call need to be updated since that method is deprecated in fflib_QueryFactory?

But I guess you are right, I can just get the configured Query Factory via newQueryFactory() method from Selector and call the methods from QueryFactory themselves.

from fflib-apex-common.

@afawcett So, to continue on what I was saying before, on very hack-ish way I can add public method like that in fflib_SObjectSelector.

  public fflib_QueryFactory addQueryFactorySubselect(fflib_QueryFactory parentQueryFactory, Boolean includeSelectorFields, String relationshipName)
    {       
        fflib_QueryFactory subSelectQueryFactory = 
            parentQueryFactory.subselectQuery(relationshipName);
        return configureQueryFactory(
            subSelectQueryFactory, 
            m_enforceCRUD, 
            m_enforceFLS, 
            includeSelectorFields);
    }

To use your sample example, following method call will become

public List<Opportunity> selectByIdWithProducts(Set<ID> idSet)
    {
        fflib_QueryFactory opportunitiesQueryFactory = newQueryFactory();

        fflib_QueryFactory lineItemsQueryFactory = 
            new OpportunityLineItemsSelector().
                addQueryFactorySubselect(opportunitiesQueryFactory);

something like this after the changes...

public List<Opportunity> selectByIdWithProducts(Set<ID> idSet)
    {
        fflib_QueryFactory opportunitiesQueryFactory = newQueryFactory();

        fflib_QueryFactory lineItemsQueryFactory = 
            new OpportunityLineItemsSelector().
                addQueryFactorySubselect(opportunitiesQueryFactory,true,'OpportunityLineItems');

Thoughts?

from fflib-apex-common.

Sorry for the delay, yes that looks great. Can you do a PR?

from fflib-apex-common.

Hi @afawcett , sure thing. Will do that.

Happy Holidays!

from fflib-apex-common.

👍

from fflib-apex-common.