Selected tests in fflib_SObjectSelectorTest fail in an org with encryption enabled on Account.Name about fflib-apex-common HOT 2 CLOSED

@nicholas-sullivan thanks for the fix!

from fflib-apex-common.

It looks like the fix to address the order by field in toSOQL_When_SystemModeAndChildRelationship_Expect_WellFormedSOQL is leveraging the order by field for the main query and the subselect, but the subselect order by field could be different.

String expected = String.format('SELECT name, id, annualrevenue, accountnumber, (currencyisocode, )?\\(SELECT name, id, amount, closedate(, currencyisocode)? FROM Opportunities ORDER BY {0} ASC NULLS FIRST \\) FROM Account WITH SYSTEM_MODE ORDER BY {0} ASC NULLS FIRST ', new List<String>{sel.getOrderBy()});

In our case, the Account Name field is encrypted but the Opportunity Name field is not encrypted. So the expected result replaces with CreatedDate in both the main query and the subselect, but our actual result uses CreatedDate for the main query and Name for the subselect.

Apologies if this should be reported differently.

from fflib-apex-common.