What's the current state of reflective lookups in Unit of Work? about fflib-apex-common HOT 7 CLOSED

Looks like it doesn't, as per the following unit test. I'll have a play and see if I can make something work.

I'm thinking, because reflective lookups can't be required, the UnitOfWork could do two DML passes on those records. One to insert them and get Ids, and another to backfill the reflective lookups and update if required.

@IsTest
private static void reflectiveLookups()
{
    fflib_ISObjectUnitOfWork uow = Application.UnitOfWork.newInstance();
    Product_Category__c productCategory1 = TestObjectFactory.createProductCategory( uow );
    Product_Category__c productCategory2 = TestObjectFactory.createProductCategory( uow, productCategory1 );
    Product_Category__c productCategory3 = TestObjectFactory.createProductCategory( uow, productCategory2 );
    uow.commitWork();
    productCategory1 = [SELECT Id, Parent_Category__c FROM Product_Category__c WHERE Id = :productCategory1.Id];
    productCategory2 = [SELECT Id, Parent_Category__c FROM Product_Category__c WHERE Id = :productCategory2.Id];
    productCategory3 = [SELECT Id, Parent_Category__c FROM Product_Category__c WHERE Id = :productCategory3.Id];
    System.assertEquals(null, productCategory1.Parent_Category__c);
    System.assertEquals(productCategory1.Id, productCategory2.Parent_Category__c, 'The category should be related to a parent category');
    System.assertEquals(productCategory2.Id, productCategory3.Parent_Category__c, 'The category should be related to a parent category');
}

System.AssertException: Assertion Failed: The category should be related to a parent category: Expected: a0KO0000004aLS0MAM, Actual: null

from fflib-apex-common.

@afawcett I've added support for reflective lookups to my fork. Can you turn this into a feature request, and I'll do a pull request for review.

from fflib-apex-common.

It's maybe because its been quite a long week, but can you elaborate more on what a 'reflective lookup' is?

from fflib-apex-common.

Phew, tough sprint. Finally got some head space back.

By reflective lookup, I mean a self lookup, or a self relationship. A lookup that points to the same SObjectType on which it's created.

I've patched my fflib fork to handle self lookups and it's working well. Sure there is a performance hit, but I've found doing an insert followed by an update is much friendlier than trying to chain DML inserts within an SObjectType.

from fflib-apex-common.

Thanks @loganm, sounds interesting, looking forward to taking a look at this.

In the meantime have you seen this long standard PR from @adtennant?

#23

from fflib-apex-common.

My solution for cyclic dependancies has been in play on my org for a while now, and hasn't spat the dummy once. So I'll open a pull request of its current state for review.

from fflib-apex-common.

I don't know if this is still true .. please reopen with a repro case if so

from fflib-apex-common.