Generate true Typescript enums about orval HOT 13 CLOSED

The fix appears to be a one-liner, but I'm not familiar with this project - I don't know how to build it.

packages/core/src/getters/enum.ts, line 93 should be

        `  ${keyword.isIdentifierNameES5(name) ? name : `'${name}'`}= ${val},\n`

from orval.

PR for documentation update would be great! cc @soartec-lab

from orval.

PR welcome

from orval.

@soartec-lab are you submitting this PR or is @rnm-sxm ?

from orval.

@melloware

I can move forward with this response once the current response is finished, but out of respect for @rnm-sxm who reported the issue, I'll wait for a moment for a response 👍

from orval.

OK I assigned to both of you and you guys can work it out!

from orval.

@soartec-lab Thanks for taking this over.

from orval.

This was added in 6.21.0: #907

Is it not working for you?

#1058

from orval.

Thanks for pointing this out. This option is apparently not enabled by default (I'm using CLI), and is not documented on the main web site.

from orval.

There is still a bug related to the way the x-enumNames is used. It ends up generating enums with colons (Color2) instead of equals:

export enum Color2 {
  black: 0,
  white: 10,
  red: 20,
  green: 30,
  blue: 40,

}
export enum Color1 {
  black= 'black',
  white= 'white',
  red= 'red',
  green= 'green',
  blue= 'blue',
}

from orval.

Cc @dsthode who made this change.

from orval.

Thank you for sharing this issue. I will also check the PR. looking forward to it 🙌

from orval.

No, I haven't started yet.

@rnm-sxm

If you don't, I can also respond to this next to the other responses.

from orval.