Deserializing OpenAPI date and datetimes as JavaScript Date objects about orval HOT 9 CLOSED

Need to be reimplemented since v5. I will do it if you are still interested or someone else?

from orval.

+1 for this, this is what openapi-generator does it makes then Date objects.

from orval.

Hello,

First thanks for your interest and your investigation.

For me, the string is the appropriate default type since the type Date doesn't exist in a JSON. But we could find a proper way to override this and transform them into Date objects. More like a mix of this and the mutator functionality.

To solve this at the moment you could use the mutator feature to transform your payload automatically and normally everything should work correctly since I am using the type returned by the mutator function.

from orval.

For me, the string is the appropriate default type since the type Date doesn't exist in a JSON

JSON is a bit old format which doesn't even have proper support for numbers or object keys, that's why formats like JSON5 are being created. I actually thought that orval focuses on TypeScript types, not what JSON offers.

To solve this at the moment you could use the mutator feature to transform your payload automatically and normally everything should work correctly since I am using the type returned by the mutator function.

I think this is a different thing. Yes, there will be a need to create a mutator, since Axios also deserializes dates to strings (JSON.parse() doesn't have any support for dates). And that is why I suggested this to be an option in orval's configuration, so that by default dates are still typed as strings.
Looking at the current examples, what I want is, in the pet.ts, the Pet to have a field of type Date (if it has such field in the API definition of course).
It will not work out of the box by just using mutator and I believe a change in the library itself is needed. It could be a non-breaking change and it could be turned on via a configuration flag.

from orval.

Ok then we could add a property date: boolean in the override section which will put the type Date in the definition and you would do the parse of the payload in your project with the transformResponse from axios for example.

from orval.

@techquestions I did the implementation and the example in this pull request #107. Can you check if this is what you want?

from orval.

@anymaniax I'm interested having Date objects for our models.

How difficult would this be to re-implement on latest? or to have a mutator to use https://github.com/moment/luxon/ DateTime objects?

from orval.

PR Submitted. Wasn't quite sure how to add unit tests.

from orval.

Thanks for releasing 6.6.0 i just updated my project and it works like a charm!

from orval.