Discriminators are not taken into consideration when inlined in response about orval HOT 3 OPEN

Putting the discriminator on the base class also works. But having the discriminator on the response is valid according to the spec: https://swagger.io/docs/specification/data-models/inheritance-and-polymorphism/

from orval.

PR is welcome?

from orval.

I realize there is two ways this could be solved, but I'm not sure which is the way to go. Either we add the discriminated property to the types, or we add it to the combined response type.
That is, either:

export type TypeObj1 = Base & {
  moreProp?: string;
  type: TypeObj1Type;
};
export type TypeObj2 = Base & {
  prop?: string;
  type: TypeObj2Type;
};

or

export type GetApiSample200 = (TypeObj1 & { type: TypeObj1Type }) | (TypeObj2 & { type: TypeObj2Type });

I assume the first one is the wanted one, but I'm unsure if there could be implications with changing the component schema based on the response schema. Could there be two responses which return the same objects, but discriminate on different properties? If so, option 2 is the safe option.

from orval.