anverbogatov / openweathermapkit Goto Github PK

Optional(Swift.DecodingError.keyNotFound(CodingKeys(stringValue: "deg", intValue: nil), Swift.DecodingError.Context(codingPath: [CodingKeys(stringValue: "wind", intValue: nil)], debugDescription: "No value associated with key CodingKeys(stringValue: "deg", intValue: nil) ("deg").", underlyingError: nil)))

This error happens only sometimes and i cant figure out where it really happens.

Hi any dates for releasing apple watch app yet?

Many thanks

Hi,
When the city name has a blank space, the URL() call fails, and get returns without calling OpenWeatherMap API. Therefore, in

internal func get<T : Codable>(from url: String, callback: @escaping (T?, Error?) -> ())

instead of:

        guard  let serviceUrl = URL(string:url) else {
            return
        }

You could add something along the lines:

        guard let encoded = url.addingPercentEncoding(withAllowedCharacters: .urlQueryAllowed), let serviceUrl = URL(string:encoded) else {
            callback(nil, NSError(domain: "OpenWeatherMap.NetworkManager", code: -1, userInfo: [NSLocalizedDescriptionKey:"Could not encode \(url)"]))
            return
        }

thanks!