antonnyman / embroidery Goto Github PK

If I have two controllers with the same name, init() runs twice (which is correct), but is it a good thing?
@Skalman

Today you can only write controllers with camelCasing.

✅

<div data-controller="myController"></div>

❌

<div data-controller="my-controller"></div>
<div data-controller="my_controller"></div>

Should we support multiple types of casing or only support camelCase?

Let's leverage types and intellisense!

We should add proper tests. But how? Testing library? AVA? Karma? Jest?

If you try to insert a partial into the DOM it won't be recognized by Embroidery.

⚠️ This is from the new typescript api!
Example:

<!--- template -->
<div data-controller="multiple">
  <button data-action="greet">Greet</button>
  <span data-target="hello">Hello to you</span>
  <span data-target="hello">Hello to me</span>
</div>

export const multiple = {
  greet({ hello }) { // <- Only returns the last target
    console.log(hello.innerHTML) // Result: "Hello to me"
  }
}

We should support data targets that share the same identifier as an array, for example:

export const multiple = {
  greet({ hellos }){ // Should we pluralize identifiers if there are multiple (like stimulus)?
    hellos.map(hello => console.log(hello.innerHTML))
  }
}