anthify / es6-sass-hotreloading-docker-wordpress-theme Goto Github PK

A small change but will increase your credibility. As an experienced WordPress developer I can tell you that all true WordPress Devs cringe when they see WordPress spelled with a lower case "p" and not a capital "P". There is even a function in the documentation written to correct "Wordpress" to "WordPress"

https://codex.wordpress.org/Function_Reference/capital_P_dangit

So... Small change but you will have a big effect.

Some comments on the repo code from reddit user Xpertbot

I find it awkward to have the theme files inside a src folder. wouldn't it be better to have it more like wp-content/theme/your-name/* that way is obvious where the docker and other config files should live? Also, is this based on underscores theme builder? it kinda seems like it.

I personally would not build into style.css, because style.css file can be modified through the WP admin and it be deleted if client decides to edit through WP-Admin. I would have an empty styles.css file with the theme headers and enqueue it as last style so any changes in it take precedence over other stylesheets.

try to minimize the number of actions you use such as, combining JS and Stylesheets on wp_enqueue_scripts to 1 function.

PHP files that have no HTML in them should not have a closing ?>

I couldn't find where the sidebars where being registered so I am unsure if sidebar.php actually displays anything.

I personally like having a partials folder where any files such as loop.php live that way anything that's outside of it at the theme root level are Wordpress high level templates. It's a good way to have a good structure on it.

Bug

New subfolder in src requires an explicit mention in the gulpfile.babel.js paths in order to be compiled.

Solution

Instead of adding paths to be included, add a path match for stuff that needs excluded as it's purpose to not copy over pre-compiled assets (sass).