Code Monkey home page Code Monkey logo

prj-rev-bwfs-dasmoto's People

Contributors

ansteadm avatar

Watchers

James Cloos avatar

prj-rev-bwfs-dasmoto's Issues

Sections

Good job on separating the HTML into sections! One thing you might want to consider is changing the <div> into a <section> to improve the semantics of your code.
If you aren't familiar with semantic HTML: http://www.hongkiat.com/blog/html-5-semantics/
Example:

<!-- First section -->
<section> <!-- or <div>, but <section> is more semantic -->
 <h2 class="brushes">Brushes</h2>
 <img src="#" alt="#" />
 <h3>Text</h3>
 <p>
  Lorem <span class="price">ipsum</span>
 </p>
</section>

<div>
<h2 class="brush">Brushes</h2>
<img src="https://s3.amazonaws.com/codecademy-content/courses/freelance-1/unit-2/hacksaw.jpeg" alt="Paint brushes">
<h3>Hacksaw Brushes</h3>
<p>Made of the highest quality oak, Hacksaw brushes are known for their weight and ability to hold paint in large amounts. Available in different sizes. <span class="price">Starting at $3.00 / brush.</span> </p>
</div>

Summary: Meets expectations

Good job on the code! Your code meets the spec and is free from any major errors (just make sure you get the file paths correct). Take a look at the previous issues to polish up the code and make it more professional.

In terms of improvements, I would suggest taking a look at the article about semantic HTML and trying to improve your HTML to make it more semantic (ie, meaningful). It seems like an irrelevant thing, but it's what makes your code stand out as professional.

If you are interested in learning more about some HTML/CSS best practices, check out some of the links below:
https://github.com/bendc/frontend-guidelines
http://learn.shayhowe.com/html-css/writing-your-best-code/

Good job on this project and keep up the good work!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.