Code Monkey home page Code Monkey logo

tabi's Issues

TypeError: can only compare to a set

python detect_hijacks.py -c rrc01 -i mabo \
    --rpki-roa-file roa.csv \
    --irr-ro-file routes.csv \
    --irr-mnt-file maintainers.csv \
    --irr-org-file organisations.csv \
    ../../{bview,updates}.*.gz

Running hijack detection tool is throwing the error :

Traceback (most recent call last):

File "detect_hijacks.py", line 81, in <module>
  for conflict in detect_hijacks(**kwargs):
File "build/bdist.linux-x86_64/egg/tabi/emulator.py", line 146, in detect_hijacks
File "build/bdist.linux-x86_64/egg/tabi/annotate.py", line 163, in annotate_if_roa
File "build/bdist.linux-x86_64/egg/tabi/annotate.py", line 222, in annotate_roa_announce
TypeError: can only compare to a set 

Description of the "all.hijacks.json" fields

Hello,

I have unzipped "all.hijacks.json.gz" file and I am not sure about the signification of each json fields. There are some informations about some fields and I tried to answer :

  • collector : BGP collector which has been hijacked ?

  • conflict_with :
    prefix : address block of the hijacker ?
    asn : ASN of the hijacker ?

  • timestamp : when the announce was received (UTC timestamp)

  • peer_ip : IP of the BGP peer (neighbor) which received the announce (so we talk about the hijacker ?)

  • peer_as : AS of the BGP peer (neighbor) which received the announce (so we talk about the hijacker ?)

  • announce :
    prefix : address block of the hijacked ?
    asn : ASN of the hijacked ?
    as_path : List of ASN used to reach the hijacked ASN ?

  • type : either "U" if the announce was received from a BGP update or "F" if it was from a BGP full view

  • asn : ASN of the hijacked or the hijacker ?

Dealing with false positives

Hi @nv-anssi ,

I have analysed the results of detection tool with our older RIB files and I suspect there false positives.

{"timestamp": 1489445634.0, "collector": "rrc01", "peer_as": 4755, "peer_ip": "121.244.206.224", "announce": {"type": "F", "prefix": "1.12.0.0/16", "asn": 4847, "as_path": "4755 6453 4134 4847"}, "conflict_with": {"prefix": "1.12.0.0/14", "asn": 18245}, "asn": 18245, "type": "ABNORMAL"}

Here prefix -"1.12.0.0/16" is said to be Abnormal for "asn": 4847, "as_path": "4755 6453 4134 4847

But the history of the RIB files shows that the ASN 4847 has been consistently advertising the prefix 1.12.0.0/16 and seems to be maintaining its stability.

So according to some papers/algoithms they are not abnormal. How are you trying to deal with such false posivities.
Please help me to understand If I am wrong here

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.