anksh1997 / covid19-cli Goto Github PK

Thank you for brainstorming
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Describe the bug

After fixing issue #14
We need a brand new screen shot in Readme.md

Describe the bug
The first digit is missing in every number.

To Reproduce
Steps to reproduce the behavior:

1. covid19 India -s Maharastra

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [Linux (Ubuntu)]
• Terminal bash

Additional context
It seems that fixing the Indian comma #14 issue caused this.

Describe
We are having code redudancy while parsing country and state details, they are having same cloned code

Solution
Instead we can have only one global parser function called from functions.py for both of the parsings

Describe the bug
Colouring isn't happening on windows.
Need to improve the code Or need an alternate approach to colour the output

Expected behavior
Coloured output should be there.

Screenshots

Desktop (please complete the following information):

• OS: [Windows]
• Terminal [Microsoft CMD]

Thank you for brainstorming
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Thank you for brainstorming
Is your feature request related to a problem? Please describe.
Its not actually a problem its an enhancement
In both of the APIS we are using some code words like
covid19 India --state mh llike MH here
or
covid19 Gbr like GBR here (Great Britain)

Describe the solution you'd like
We will like to have CODES.md

• Steps to go to apis list out codes and document them into CODES.md
• API :-> https://api.covid19india.org/data.json
• API:-> https://corona.lmao.ninja/countries

Save CODES.md file either on root or in docs/ folder
but don't forget to give link in README.md

• The README.md file is quite boring and incomplete
• Update the file according to your creativity

Describe the bug
whenever tried to run the program I get an error saying
locale setting unsupported . Maybe related to number formatting on windows

To Reproduce
Steps to reproduce the behaviour:

1. change working directory to covid19-cli
2. run python covid19/__main__.py india

Expected behaviour
should display the data properly

Screenshots

Desktop (please complete the following information):

• OS: Windows 10
• Terminal : git bash

Additional context
I think the problem is with locale.setlocale() on windows

Thank you for brainstorming
You are welcome. Thank you too, for making this.
Is your feature request related to a problem? Please describe.
It is always difficult to gauge how many lakh, crore people are affected. Say 533088
Describe the solution you'd like
Ensure Indian style commas. For example, write 533088 as 5,33,088
Describe alternatives you've considered
If not possible 533,088 American style numbering would be bearable too.
Additional context

Not necessary