anitab-org / powerup-android Goto Github PK

When the app starts for the first time, the user should be directed to the changing room directly

The map elements can have relevant labels such as School, house

On mobile devices on landscape mode, the different body parts of the avatar are not correctly places and lay on top of each other. This should be fixed so the avatar is correctly displayed

This is a design task, no coding!
The current lower bar on the conversation screen shows bars for the values of the different powers, but doesn't state what each of those values are. Design a UI and/or an interaction to show this. Several approaches could be valid like showing the name in a suitable place on the bar area or showing this information on a dialog on touch.
You should use Illustrator, Photoshop or similar tools for this task. You can also use a prototyping tool like Invision if you want to show the interaction

When on a horizontal display, the avatar is shown wrong with the head not correctly placed. This should be fixed so the avatar is correctly displayed in both vertical and horizontal displays

Everyone can work on this task. If you find bugs in the application, you can create a new Issue specifying what the issue is

As one scenario is completed, the second is started automatically without asking the user which scenario should be played next nor gives any information about the points earned in the scenario.

If this needs to be done ,Can I implement this such that at the end of the scenario,

1. A page displaying information about points opens, which has button which will lead to map.
   or
2. a toast or dialog box displays points and opens map activity directly.

Add an "About" screen with information about the game, its goal, its creators and how it was implemented (as a Systers' Open Source project) along with other information you think is useful.

The screen could be implemented as an Activity or as a dialog.
You can check PowerUp Handout for reference: https://github.com/systers/powerup-android/blob/master/PowerUp%20Handout.pdf

When on a horizontal display, the right part of the conversation is almost hidden below the character and can't be read. It should be placed somewhere else (possibly next to the character) in the horizontal mode so it can be easily seen

The size of the buttons, icon and text is too small for big screens (tablets). It should be resized according to the screen size

Currently there are no tests.
What about adding UI Espresso based test? Should I progress in this?

Currently, the change room screen displays well in small screens like phones, but on tablets the content stays in the upper left corner. The content should instead be centered and made bigger to fit the tablet screen and still work well on phones

startActivityForResult() should be used when we are expecting some result back as it waits for callbacks from the started activity. However, there are few places in the application where this has been used unnecessarily. I intent to replace these with a simple startActivity(). Eg

private OnClickListener onClickListener = new OnClickListener() {
        @Override
        public void onClick(View v) {
            Button b = (Button) v;
            if (getmDbHandler().setSessionId(b.getText().toString())) {
                Intent myIntent = new Intent(MapActivity.this, GameActivity.class);
                startActivityForResult(myIntent, 0);
            } else {
                Intent myIntent = new Intent(MapActivity.this, CompletedSceneActivity.class);
                startActivityForResult(myIntent, 0);
            }
        }
    };

Intro screens appear when the user installs the app and uses it for the first time. These screen guide the user through the app and give details about the features of the application. I intend to create intro screens using the PaoloRotolo AppIntro library which is a widely used library to create intro screens.

This task is very open. The game will have minigames where players can earn more points. These games are not defined, but you can suggest new minigames to the PM team

When replay or backtoMap is pressed from within a scenario, the corresponding activity is called but current not finished which leads to multiple instances of the same scenario in various stages. Also the visibility of buttons needs to be fixed accordingly. Willing to work on this if required.

When using the back button from the conversation or the end of conversation screen, it should directly take to the map screen rather than replay the entire conversation

Although, almost all the resources have been placed correctly in their respective places (integer.xml, dimen.xml , colors.xml) , there are few hardcoded integers and dimens still present in pgame.xml and simplerow.xml . I intend to remove these and remove the remaining hardcoding.

This should contain a basic document containing the correct files needed in .gitignore of an AndroidStudio project. This will make it easier to avoid getting the wrong files committed to the project.

Following constants have been named incorrectly:

    public static int eyesTotalNo = 3;
    public static int clothTotalNo = 4;
    public static int hairTotalNo = 1;
    public static int faceTotalNo = 3;

Constants should be named in ALL_CAPS. Also constants should be declared as final. The correct code would be:

    public final static int EYES_TOTAL_NO = 3;
    public final static int CLOTH_TOTAL_NO= 4;
    public final static int HAIR_TOTAL_NO = 1;
    public final static int FACE_TOTAL_NO = 3;

Why not use startActivity() instead of startActivityForResult( , ) in the .java files? According to me, it is more appropriate as we are not expecting any result back to the previous page and it is also more readable.

After a scenario is completed, the user should be shown all the points she or he has earned during that specific scenario

If user goes to map activity via change room, on pressing back she is directed back to change room instead on main menu as it should be.

In the creation room, both arrows are pointing the same direction. This task consists on reversing one of them, so they point the right direction

Currently, there is a limited set of clothes in the app. You can create more by modifying the current ones using Photoshop or Illustrator. These can then be added to the changing room.

In horizontal mode AND in big displays, such as tablets, the character speaking and the text associated to them and horizontally aligned. However, since the texts are closer to the other character than to the speaker, the conversation is misleading. The positions of the conversation boxes should be swapped in this cases (not in vertical mode for phones, only for horizontal mode and big displays in any orientation).

Currently on changing the orientation of App.The AppState gets lost and we are set to default one.

While Writing test for PR #87 ,I encountered this.
I will make a PR to fix this shortly. 😄

The game is currently optimized for phones.

Create a new creator room layout for horizontal displays (using qualifiers) so this works on tablets and phones in horizontal mode. Read more about screen qualifiers here: http://developer.android.com/intl/es/guide/practices/screens_support.html

Currently the database is maintained locally converted from csv files which is a process that can get cumbersome if the data grows. I suggest Sugar ORM [http://satyan.github.io/sugar/getting-started.html] as it will make handling the data easier, make querying simpler and also reduce a lot of code, leading to reduced application size. This task can be a long one though and may require some discussion.

The game is currently optimized for phones. Therefore, the buttons for the different locations in the map are placed related to the phone layout.

Create a new map layout for horizontal displays (using qualifiers) so this works on tablets and phones in horizontal mode. Read more about screen qualifiers here: http://developer.android.com/intl/es/guide/practices/screens_support.html

The current start screen buttons are suitable for mobile screens, but they get pixelated in bigger screens. This task doesn't include any coding. It consists of creating bigger resolution buttons with Illustrator, Photoshop or similar tools

In the current UI, health and power are static values shown as an image. This task consists of changing this so the actual values are shown in the lower part of the game

An introductory splash screen to give user familiarity with the game would be beneficial as is the norm with any gaming application.

Application crashes by clicking the home image button on the top right corner of the pgame page.

We can take the name of the user as input and display it in the points bar during the game. It increases the user's interest and makes the app more dynamic.

In the map screen, the continue button should be removed so only locations in the map open up conversations

Currently, the change room is opened directly the first time the game is played without showing the start activity. Instead, the start activity should be shown when opening the app and then, when pressing "start" for the first time, the change room should be shown instead of the map

Currently, during conversations, the text is shown in boxes that don't always fit the text that is inside. This task consists on improving this UI by making the boxes fit the text that is inside.

If the user clicks on replay or map button once from a scenario, these buttons are permanently disabled from being used again, is that purposely designed or something to be fixed? Willing to work on it if required.

Currently, there is a separate activity for each screen. Activities also have a lot of other responsibilities such as lifecycle management, platform interaction, etc. Fragments eliminate this problem by taking on the UI details and leaving the other responsibilities to the Activity.

Launching a separate activity for each app screen is terribly inefficient, since the system will try to keep them in memory as long as it can. Killing one won’t free the resources used by the others. We should consider using Fragments whenever it's possible, as it makes the code easier to maintain and control.

For example: we can keep StartActivity and move AvatarActivity, AvatarRoomActivity to fragments.

Further information.

The font family of 'About' in about button is different than Start and New User
Similarly the 'continue' button used in the app also has different font family

UI for the two buttons map and store
Proper alignment for the buttons

Right now once the user has completed the game , she cannot replay the game . To replay she must re install the .apk file.
I think it would be better if , we provide a option to replay the game. If suggested we can also implement the feature to activate the replay button only when the entire game is finished.

Add more options in avatar or allow user to add her own picture so as to connect more with the conversation. Also add your own name as avatar name.

In the AbstractDbAdapter.java, I noticed that we have used hardcoded column names of databases (avatar, questions). Instead, we could create a DbContract.java that defines these database schemas. This will help us a lot. I would like to fix this. Is this a welcome contribution right now?

The new user title can be changed to new avatar as there the user selects new avatar there

Clicking on the replay button on the GameActivity.java again starts GameActivity.java via an Intent. Thus GameActivity.java is stacked twice and we have to click the back button two times to return to the MapActivity.java. Similarly for goToMap button we have to press back button twice to return to StartActivity.java.
Problem can be fixed by popping the stack top with button click.

Right now their is a default avatar for Rosie which doesn't change even if user chooses something else in Change Room. Fix this so that chosen avatar is saved and displayed.

Currently, after clicking continue in the change room, the user is redirected to the conversation activity. Instead, change it to redirect to the map activity