animekaizoku / enterprisealrobot Goto Github PK

Description

To check if a variable is equal to one of many values, combine the values into a tuple and check if the variable is contained in it instead of checking for equality against each of the values. This is faster, less verbose, and more readable.

Occurrences

There are 6 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/Dank-del/EnterpriseALRobot/issue/PYL-R1714/occurrences/

How to reproduce

• Just try joining a group with kigyo in it, with greetings enabled, no other thing required

Kigyo doesnt respond to any join or leave events on Prod

• in my testing it does work locally, just not in prod, which might be a hint towards corrupt data

Checking the logs of the production kigyo, it does not mention any error arising from greetings, or error at all

https://github.com/TheHamkerCat/LunaChatBot

I think it will make the bot more interesting. LOL

Please see here after reading this issue.

Welcome in a group, is true by default, so this problem is somehow rare.
But if a user removes the welcome message with command: /welcome off, the /cleanservice on will have no effect at all.
If a user joins, kigyo won't delete the service message.

Users who don't want to see a welcome message, but want kigyo to delete service messages (such as User X removed User Y or User X left the group), will be in trouble.

Description

Comparisons to the singleton objects, like True, False, and None, should be done with identity, not equality. Use “is” or “is not”. Identity checks are faster than equality checks. Bad: python value = fx() if value != None: print(value) Good: ```python value = fx() if value is not None: …

Occurrences

There are 29 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/Dank-del/EnterpriseALRobot/issue/FLK-E711/occurrences/

..

Chat (Telegram)