anhskohbo / wp-cli-themecheck Goto Github PK

View Code? Open in Web Editor NEW

38.0 2.0 10.0 30 KB

Run Themecheck in WP_CLI

Shell 1.57% PHP 98.06% Gherkin 0.38%

wp-cli wordpress themecheck themeforest

wp-cli-themecheck's Introduction

anhskohbo/wp-cli-themecheck

Quick links: Using | Installing | Contributing

Using

wp themecheck

Installing

Installing this package requires WP-CLI v0.23.0 or greater. Update to the latest stable release with wp cli update.

Once you've done so, you can install this package with wp package install anhskohbo/wp-cli-themecheck.

Contributing

We appreciate you taking the initiative to contribute to this project.

Contributing isn’t limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Reporting a bug

Think you’ve found a bug? We’d love for you to help us get it fixed.

Before you create a new issue, you should search existing issues to see if there’s an existing resolution to it, or if it’s already been fixed in a newer version.

Once you’ve done a bit of searching and discovered there isn’t an open or fixed issue for your bug, please create a new issue with the following:

What you were doing (e.g. "When I run wp post list").
What you saw (e.g. "I see a fatal about a class being undefined.").
What you expected to see (e.g. "I expected to see the list of posts.")

Include as much detail as you can, and clear steps to reproduce if possible.

Creating a pull request

Want to contribute a new feature? Please first open a new issue to discuss whether the feature is a good fit for the project.

Once you've decided to commit the time to seeing your pull request through, please follow our guidelines for creating a pull request to make sure it's a pleasant experience:

Create a feature branch for each contribution.
Submit your pull request early for feedback.
Include functional tests with your changes. Read the WP-CLI documentation for an introduction.
Follow the WordPress Coding Standards.

wp-cli-themecheck's People

Contributors

Stargazers

Watchers

Forkers

jgraup fjarrett neps-in codeinwp thedigitaloctopus preda-bogdan cristian-ungureanu girishpanchal30 imnavanath helongquan

wp-cli-themecheck's Issues

Latest dev-master not being installed

Hi,

It looks like #7 was merged, but those changes are not reflected in my CI/CD pipeline, or locally, when I install the package. If I ssh into the package directory and do a git pull the changes update and the tests pass. Why is it that doing wp package install ... doesn't pull the latest changes from the master branch?

This is in a CI/CD pipeline, after running wp package install:

Only way around this right now is to cd into the package directory and do a git pull.
cd ~/.wp-cli/packages/vendor/anhskohbo/wp-cli-themecheck && git pull

I can't imagine this is a cache issue, as it's been 3 days since the fix was merged into master.

Thanks

Required: The "<title>" tags can only contain a call to "wp_title()". Use the "wp_title filter" to modify the output.

Despite using

if ( ! function_exists( 'theme_setup' ) ) :

// @since Themename 1.0

function theme_setup() {
   // Add theme support for document Title tag
  add_theme_support( 'title-tag' );
}

endif; // theme_setup

add_action('after_setup_theme', 'theme_setup' );

I get

<title>" tags can only contain a call to "wp_title()". Use the  "wp_title filter" to modify the output.

when using Themecheck with wp-cli. I have no title tag in the header.

This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.

Support for all other checks are added and work.

What can I do to pass this check in WordPress 4.8 please?

I have seen and tried all the other suggestions regarding the title-tag function but none of it works, not even https://gist.github.com/tommcfarlin/958b57e0b7c78e9ff13e.

Fatal error when running theme check with PHP 8

Fatal error: Uncaught TypeError: in_array(): Argument #2 ($haystack) must be of type array, null given in /root/.wp-cli/packages/vendor/anhskohbo/wp-cli-themecheck/command.php:188

Ref: https://tinyurl.com/2g5hoj3z

Fatal error when running theme check

PHP Fatal error: Uncaught Error: Call to undefined function tc_get_theme_data() in /root/.wp-cli/packages/vendor/anhskohbo/wp-cli-themecheck/command.php:142

It seems that the function was removed WordPress/theme-check@d1f800d

Use a non-zero exit status when tests do not pass

In order to use this package in automated workflows, the command should only use a 0 exit status when a theme passes all the tests:

Success: Congratulations! Theme is passed the tests!
$ echo $?
0

As it stands today, the exit status is always0, even for errors. So in order to integrate the command into a CI/CD pipeline you have to grep the output and pray it never changes:

Error: One or more errors were found for Primer!
$ echo $?
0

themecheck not returning any results

Hi there,

We're using theme-check in our CI/CD pipeline to ensure our theme passes the checks on each release. However, in the latest release we're now getting a failing build with a Exited with code exit status 255.

We're running theme check through the WP CLI command wp themecheck --theme=go --no-interactive. Any ideas what might be causing this? Is it possibly the run is exhasting the memory? I'm also getting the similar results on my local machine.