andyfleming / browserupdatewarning Goto Github PK

he...

the option command is wrong

should be that:

allowCloseAndContiue: (true or false)

Hi Andy,

Another issue found.

Consider the following call:

window.addEvent('domready', function() {
  var browserWarning = new BrowserUpdateWarning({
      shade: false,
      // Show Continue to site button
      allowContinue: true
    });
    browserWarning.check();
  });

Notice: shade option is set to 'false'.

Now look the 'Continue to site >' button's onclick event defined in line nr. #153:
html += '<a href="javascript:void(0);" class="continueToSite" onclick="$('BrowserUpdateWarningShade').hide();$('BrowserUpdateWarningWrapper').hide();">Continue to Site »</a>';

The problem: the BrowserUpdateWarningShade.hide() methode is called unconditionally, namely if 'shade' option was set to 'false' this will generate JS error '$("BrowserUpdateWarningShade") is null' - obviously, as we have not created the object before.

Cheers.

Hi Andy,

FYI: you are using the HIDE methode in the onclick event of the 'Continue' button.
Element's hide methode is defined in Mootools More's Element.Shortcuts.js.

Just try to include your script into any HTML page without pulling Mootools More, when you click on the 'Continue' it will throw an error:
$BrowserUpdateWarningShade.hide() is not a function

Ciao.