andy-portmen / undo-closed-tabs-button Goto Github PK

Setting remember history for 21+ history makes the menu starts to have problems. FOr example at 21 "Clear history" disappears 22 makes "Show full tab history" disappear and so on. Seems like the menu can't make itself bigger than 20 items. Probably a scroll bar should be added to be able to display more than 20 items.

God, this would be lovely.

After increasing from 25 to higher number, clicking SAVE, it resets to 25.
using latest windows, latest chrome browser.

I noticed this with other similar extension too called browser tab history or something like that. Sometimes when I click 1 item of the list to recover it the first click does nothing I have to re open the menu and click it again for it to work. Is this something firefox does or something about history of the browser or what could it be?

I noticed that clear history clears all the history of the browser which is not what I was expecting. Could you make it to only clear the list of the closed tabs instead and keep the history the same? and if that's not possible could you make it so that it only cleans the entries shown on the list and not all the history of the browser please?

Enhancement requests:

Change the toolbar icon to something that does not appear to be in a permanently 'disabled' state.

Add options to remove/not display the popup menu entries for:

1. Open All in Tabs
   -- very unlikely to be needed in my experience
2. Clear History
   -- seems odd/out of place to include in a plugin directed at unclosing recent tabs
   -- something I would never want to do
   -- others have commented that they find this option dangerously too easily selected

Thanks,
Gerald

This add-on is marked incompatible with Firefox 57. If this isn't changed, this addon will be useless in a month. Which would be very unfortunate because I really like it. It happens too often that a tab was accidently closed because the mouse cursor was moving in strange ways or the tabs were moving beneath the cursor. It's good to have that tab with its full state, including the history, available.

Alternatively, are there any other addons that do the same in Firefox 57? Most addons I've found for Chrome a few years ago just re-opened the last URL of a tab, but didn't restore their history. Firefox can do that alone.

In the original version of Undo Closed Tab if you clicked the icon it just automatically restored the last closed tab. If you wanted to see the full list you would just click and hold it. I think this makes more intuitive sense because the majority of time you're only looking to restore the tab you just closed, so a single click is much quicker. Also, it would bring it more inline with how other buttons work like back and forward, i.e. one click goes back, and if you hold you can see your previous pages.

Thanks!

As mentioned in #3, the add-on will be migrated to WebExtensions.
What kind of options will be possible and when will it be available? (the commits here seem outdated).

On firefox when pressing show full history it tries to go to chrome://history/

All the closed tabs are displayed in the drop-down list, but will you be able to select option to display only the closed tab in the current window?
It is useful to be able to display only the tabs of the current window like before (not web-ext).

The latest update hasn't been pushed to GitHub. Can you please update the repository to version 0.1.7?

Ideally, this would use the browser styles from https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Browser_styles

right now the menu to restore items in the toolbar looks out of place (wrong font, doesn't look like a menu, colors).

Steps to reproduce:

1. Install Undo Closed Tabs Button (revived) in a new profile on Windows.
2. Click hamburger menu > Customize.
3. Move the extension icon next to min/max/close buttons.
4. Put another icon between extension icon and min/max/close as below:
   
5. Click Done to exit Customize mode.
6. Restart browser.

Actual result:

Undo Closed Tabs icon is moved to directly next to min/max/close:

If I, however, enter Customize mode again, the icons return to their intended positions automatically.

Other details:

OS: Win10 1803
Browser: Firefox 60 and current Nightly

Can u add (maybe optional with a setting) to show "Recently Closed Windows" and its entries.

Also an option to hide Clear History / Forget Closed Tabs would be awesome.

can you fix the background menu? To match other menus. See the picture. taking color from the firefox theme
https://i.imgur.com/VgDEaQ3.png

Is it possible to make pressing the hardware "forwards" button active the undo close tab feature when the "forwards history" is empty for a tab?

Why is it necessary for a tab-restoring button?

Using the just released about:performance I discovered that Undo Closed Tabs Button is slowing down my Firefox:
"Undo Closed Tabs Button seems to have slown down Firefox very often. When this happens, the slowdown is generally noticeable"
Impact on framerate: 0 high-impacts, 165 medium-impact.
CPU usage: 1% (total 614400ms).
System usage: 1% (total 44237ms).
Blocking process calls: 0% (total 0ms).
Measure start: 2124 seconds ago.

Undo Closed Tabs Button 3.9.9
Firefox 47
Kubuntu 16.04 64bit

In the file:
WebExtension/data/options/index.js
the maximum for "Number of undo items displayed in the popup" is determined with:
maxResults: Math.min(chrome.sessions.MAX_SESSION_RESULTS, Math.max(2, maxResults)),
and that is 25 as I can read in the Mozilla doc about MAX_SESSION_RESULTS
But this maximum should in fact be related to the config (in about:config) for:
browser.sessionstore.max_tabs_undo
which the user can set arbitrarily.

Could you make the icons on the list only download once (idk if possible for a webext but maybe use the ones firefox already downloaded) and then use from cache or something instead of loading them every time. It tales like 3-5 seconds to load all the icons each time.

Extension seem to be hardcoding background as white BUT does not define its own font colour so in dark themes we get invisible white-on-white menu. It should either define all its own colour or not at all.

On the pictures you did put on AMO for Undo Closed Tabs Button (revived) it shows favicons but I'm not able to see the favicons.

BTW could you explain me how there are some closed tabs that have an icon to open them in an other window. Are those closed windows or just closed tabs from an other window other than the current one?

No tabs available to restore. Reports "Nothing to Restore!"

Seems to have stopped working with Firefox 62.x (currently 62.0b10). Originally, I thought it might be due to having First Party Isolation enabled, but the problem persists after disabling FPI.

Tested on Windows 10 Enterprise x64, so far.