andy-portmen / open-in-firefox Goto Github PK

Host matching (using a domain in "Open with Left-Click" > "Comma-separated list of domains") does not work on some websites such as Notion, all clicks are open externally (or internally in reverse mode).

Interestingly, URL pattern matching (using URLs in "Open with Left-Click" > "Comma-separated list of URLs") works (apart from de bug described here).

This could be due to the fact that for host matching a.hostname is used and it is undefined on apps like Notion for some reason that use relative links such as <a href="/foo">, whereas URL pattern matching method uses a.href.

see code here https://github.com/andy-portmen/open-in-firefox/blob/74b3c2fe08d42a225db4dc77c07963d83a359f0f/v3/data/inject.js#LL21C1-L40C6

edit: added reason why hostname can be undefined.

I use this extension in reverse mode in order to open all links in Firefox except the links on one domain, using a pattern in "Open with Left-Click" > "Comma-separated list of URLs" (since when using a domain name in "Comma-separated list of domains" it does not work on some websites as described here).

It works except for URLs that contain a question mark (URL with query parameters), ex. https://www.domain.com/foo?bar=1

Here are the patterns I tried:

• https://www.domain.com/(.*)
• https://www.domain.com/(.*\?.*)
• https://www.domain.com/([\/a-zA-Z\d\?=]*)

I read the URL pattern doc but I think this is an issue with the extension.

edit: after testing the URLPattern API in Chrome console, this is the default behaviour. Using chrome 114.0.5735.110.

When "Reverse Mode" is enabled, could the extension use the combination set in "Open With Keyboard and Mouse Click Combinations" to open a link normally (the same way a left-click would if the extension is absent)?