Code Monkey home page Code Monkey logo

sun-sky's People

Contributors

0xflotus avatar andrewwillmott avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

ezhangle peterzhousz 0xflotus arncarveris jlaate pclod wedusk101 alexnewtown elientumba2019 lastexile-ch lp249839965 melowntech chemjeff

sun-sky's Issues

Units and dataset used by SunRGB

Hey, first of thanks for this well-written library, and even releasing it into the public domain!
It has been really useful to me so far.

The SunRGB function gives unexpected/unplausible results for me. In an atmosphere with low turbidity, a sun at high elevation (e.g. cosTheta = 1) should have an illuminance of up to 100k lux (see for instance the measurements on page 37 of https://seblagarde.files.wordpress.com/2015/07/course_notes_moving_frostbite_to_pbr_v32.pdf). Using the reference implementation of the hosek wilkie sky model, I get these results (e.g. linear srgb (95k, 78k, 59k)) while using SunRGB returns rgb values that are usually around 2-4 times smaller (e.g. I'm getting something like (26k, 23k, 20k)). It looks like this function is supposed to return lux in linear srgb color space as well, where does the difference come from? I know that the reference implementation returns sun and sky radiance (and I'm converting that to illuminance), but the difference isn't that big since sky illuminance for this small solid angle isn't nearly that huge.
Am I just misinterpreting the values from this function? Could something be off with the dataset?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.