andreitoma8 / erc721-staking Goto Github PK

Should line 82 here be stakerAddress[_tokenIds[i]] = address(0); rather than ==

note: I am new to solidity and I want to make sure I'm understanding this correctly. thanks.

Why do you think it's better to separate token and staking smart-contracts? Is there any sense, but code segregation? We could combine these two smart-contracts into single one. If it wasn't blockchain development I would separate them into two microservices, but when it comes to paying for deployment, it's cheaper to have one sc.

Hello!

Thank you for making these contracts available for free.

I have a question that that it'd be really helpful to get an explanation from.

In the staking contract, when calling rewardsToken.safeTransfer(msg.sender, rewards);, I'm assuming the msg.sender in the ERC20 contract is going to be the ERC721Staking contract that's calling it

So basically it'll call _transfer(**ERC721Staking Address**, **Rewardee Address**, **amount**); in the ERC20 contract.

So what I'm trying to understand is how does the ERC721Staking have any tokens to start with to transfer to the rewardee ?

The rewards token constructor

will mint to the msg.sender but that's the address that deploys the contract and not the ERC721Staking contract.

Apologies if this is a silly question, I am a newbie to smart contract development :)

Thank you!

Is there a way to use an existing nft smart contract?

Have tried renaming nft.address in the deploy script, passing the contract address in constructor (wont let me verify with constructor arguments) but it doesnt seem to like anything except the contract deployed alongside the token and staking.

Where would I configure this?