andreferreiradlw / pokestats Goto Github PK

Created this issue to refactor the current existing code in pokeapi-sw.js based on the pokeapi-js-wrapped service worker.

The objective here is to create code consistency between this logic and the rest of the Workbox routes. When I tried to emplement similar logic with Workbox, the service worker is saving all the opaque responses and thus, generating massive cache sizes and quickly filling the storage quota.

When I try to filter out the opaque responses that have status code 0 with Workbox's CacheableResponsePlugin, even though the image responses return with status code 200, they are not getting cached.

Pokeapi serves data just as it is scraped from the Nintendo Pokemon ROMs. Thus sometimes it contains some hidden strange characters which were used as a hack to separate text.

Specifically, in the details pane, you are rendering the flavor text for a specific Pokemon. These almost always contain that char. Browsers render it as an arrow pointing up.

You can use this code to get rid of this annoyance:

        # Page breaks are treated just like newlines.
        # Soft hyphens followed by newlines vanish.
        # Letter-hyphen-newline becomes letter-hyphen, to preserve real
        # hyphenation.
        # Any other newline becomes a space.
        html = flavor_text.replace(u'\f',       u'\n') \
                          .replace(u'\u00ad\n', u'') \
                          .replace(u'\u00ad',   u'') \
                          .replace(u' -\n',     u' - ') \
                          .replace(u'-\n',      u'-') \
                          .replace(u'\n',       u' ')

Reference:

veekun/pokedex#321
veekun/pokedex#218

This is just a suggestion.

This project caught my eyes, it's very neat and provides a lot of info. I was thinking that maybe you could use https://github.com/PokeAPI/pokeapi-js-wrapper and especially its feature to cache images:

https://github.com/PokeAPI/pokeapi-js-wrapper#caching-images

Just enabling the SW without actually using the wrapper would be a huge benefit for subsequent page loadings.

Showcasing 25(?) at a time with a current maximum of 151 Pokemons.

Submit the first recommended Pokémon.

Currently, the service worker is only caching image responses from Github for 5 minutes. Preferably, we would like to cache these for a much longer period (at least a month).