andreacremaschi / shapekit Goto Github PK

Heya!

Could you please tag and update the podspec? The changes that you pulled from me are actually not in the podspec yet, so when I updated I lost my changes xD

Thanks!

XCode 5 dropped support for llvm-gcc, so the default compiler now is LLVM 5, and it seems to have some issues with geos: WKB geometry types are correctly identified, but when it comes to read coordinate values ( Geometry * WKBReader::readGeometry()::285) return values are incorrect.
This is a major issue since everything depends on geos..

I wrote this category for my self to use ShapeKitPolygon with MKMapView. However, I can't include it in the ShapeKit code (because that would make it dependent on the MapKit framework).

Can I put it somewhere? In the wiki, the readme, or maybe in a separate readme ("Using with MKMapView.md")?

Cheers

#import <Foundation/Foundation.h>
#import <ShapeKit.h>

@interface ShapeKitPolygon (MKPolygon)

- (MKPolygon*) MKPolygon;

@end

@implementation ShapeKitPolygon (MKPolygon)

// Recursive function
- (MKPolygon*) MKPolygon
{
    // Copies only the exterior ring!
    int numberOfCoordinates = [self numberOfCoords];
    CLLocationCoordinate2D coordinates[numberOfCoordinates];

    for (int i = 0; i < numberOfCoordinates; i++)
    {
        coordinates[i] = [self coordinateAtIndex: i];
    }

    // Copy the interior rings
    NSMutableArray *interiorMKPolys = [NSMutableArray array];
    for (ShapeKitPolygon *poly in self.interiors)
    {
        [interiorMKPolys addObject: [poly MKPolygon]];
    }

    return [MKPolygon polygonWithCoordinates:coordinates count:numberOfCoordinates interiorPolygons:interiorMKPolys];
}

@end

ShapeKitGeometry exposes GeomType, but no constants to compare against.

Inside the ShapeKitFactory:55 (classForGeometry:) it uses not a GeomType but the GeomTypeId, maybe it is an idea to expose the GeomTypeId, and the corresponding enum GEOSGeomTypes in geos_c.h:122 ?

What would be the best way to expose the type of a Geometry, and also expose constants to compare against? I can implement this and make a pull request if you want.