andersblomqvist / sulfur-potassium-mod Goto Github PK

It crash with fabric 1.17
Below i attach the log file of the crash:

https://pastebin.com/AjnZcVcY

Fortune does not work on Potassium, for sulfur however it seems to work

I'm on Fabric 1.19.2 and I have tested this with only this mod and Emerald Tools installed. I didn't think to try mining the storage blocks, but I did try all three ores.

Emerald Tools has hammers which mine a 3x3 area. While the extra pickaxes added by this mod mine the potassium and sulfur ores just fine, but the hammers cannot break the blocks. When the ores are hammered the breaking animation plays over and over but the block never breaks.

Could you add the tags to the blocks to make them hammerable? Thanks!

For parity with vanilla, both sulfur and potassium should have both stone and deepslate ores even if they do not naturally generate.

How to Issue

If you've encountered a bug caused by my mod and want to report it, please follow these simple stepps.

Create a new issue by pressing the green "New Issue" button to the right.

Have the following information:

• Minecraft version
• Mod version
• What caused the bug
• Explanation on how to create the bug
• Crash logs is very informative so please link them! (via https://www.pastebin.com for example)

It's fine if you don't know what caused the bug but please write mod and minecraft version.

Good example of an issue: andersblomqvist/enhanced-mob-spawners#15

Hello! I was test running my mod called Blame to see how well it works on modpacks and it seemed to have found that sulfur-potassium-mod does not register the ConfiguredFeatures of the ores. This can be an issue for mod compatibility as under certain conditions, unregistered ConfiguredFeatures can basically prevent other mod's registered ConfiguredFeatures from spawning if in the same generation stage.

By that I mean, if mod A adds an unregistered CF to the ore generation stage and the biome's codec reaches it first, it will choke and basically nuke mob B's registered CFs afterwards. Here's a case where BetterCaves forgot to register their CF and caused several CFs from Oh The Biomes You'll Go to stop spawning in the world: YUNG-GANG/YUNGs-Better-Caves#75

Here's a more detailed explanation of why this happens in the biome's codec:

Specifically, when you call .withConfiguration on a Feature, you create a ConfiguredFeature. This is what should be registered to the WorldgenRegisties at mod init (you can do it in FMLCommonSetupEvent so you have your config ready too if it is needed).

Anyway here's an example from my mod RepurposedStructures of me registering all my ConfiguredFeatures.
https://github.com/TelepathicGrunt/RepurposedStructures/blob/a4e3365e3867b8510952ebf658c415de6e412927/src/main/java/com/telepathicgrunt/repurposedstructures/RSConfiguredFeatures.java#L184-L185

I hope this helps!

The CFs that Blame found that are unregistered are these. It pulled those entries out of the CF's JSON to try its best to find which mod the CFs are from:

sulfurpotassiummod:potassium_ore_block
sulfurpotassiummod:sulfur_nether_ore_block
sulfurpotassiummod:sulfur_ore_block

Not a giant issue, but Sulfur Nether Ore generates in stone that isn't netherrack, and it looks out of place.