Code Monkey home page Code Monkey logo

enhanced-mob-spawners's Introduction

Enhanced mob spawners

Attempts to add vanilla friendly features to the Spawner block. Such features are:

  • Make Mob Spawners minable with silk touch
  • Right-click on a mob spawner and it will drop its monster egg corresponding to what type of entity inside.
  • Adds a chance for all entities to drop its monster egg
  • Adds Spawner Block in Creative Tabs (decorations)
  • Modify Mob Spawner stats such as count, speed and range. Example: make spawner active for a maximum of 128 blocks! Vanilla is 16
  • Customize what you want inside mod configuration file
  • Toggle spawner ON/OFF with in-game config menu or Redstone
  • Option to turn on limited spawns, via config file! Control number of entities a spawner can spawn before it dies. (currently only on latest fabric version)

See Curse mod page for more details and pictures.

Setup

For setup instructions please see the fabric wiki page that relates to the IDE that you are using.

License

This template is available under the CC0 license. Feel free to learn from it and incorporate it in your own projects.

enhanced-mob-spawners's People

Contributors

andersblomqvist avatar dylanje avatar flanks255 avatar mikeliro avatar mpustovoi avatar simgithub5 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

enhanced-mob-spawners's Issues

can't get a mob with armor

Hi,
I tried to get the spawners from a DungeonCrawl dungeon but if I retrieve the egg from a spawner that spawns a mob with armor and put it back in another spawner, the mob loses its armor. ( although I don't think the problem comes from this mod since they are vanilla mobs with armor )

Range Resetting

Hi,
the range on the spawner always resets after turning off the spawner (including powering it with redstone).
Forge 35.1.28

Drop chance dont work

Hello, i try to get a spawn egg from the mobs so i I increased the % value to 99% and it still didn't drop an egg after about 100 mobs nut everytime when i set the value on 100% it dropped everytime can somebody help me with it?

Extreme lag near spawner with spawn eggs

I am trying very high lag peaks near spawners with innovation eggs!
When I look far away to the mob spawners region my fps drops from 110 to less than 30!!!

I have almost all possible mods that help in optimizing the game, I already took sodium out completely and put it back!
Result: When I removed the monster eggs from the spawners my fps returned immediately!

Dupe bug using FTB Ultimine

How to reproduce: place a bunch of silk touched blank spawners
then just mine them at the same time

will give you 1 extra spawner every time

Running 1.16.4, forge 35.1.36, mod version 1.7.9

Conflict when using Carrier mod

(Fabric)
When using this mod with the Carrier mod, results in interference to carrying the spawner block.

Mod Page: https://www.curseforge.com/minecraft/mc-mods/carrier
Github page: https://github.com/GabrielOlvH/Carrier

When using Carrier mod, Enhanced Mob Spawners prevents the block from being picked up with their keybind + interact. Likely a conflict with a block interact event.

Starting here may be the cause of this issue.

public ActionResult onBlockInteract(PlayerEntity player, World world, Hand hand, BlockHitResult hitResult) {

Config missing values for Range

"disable_count": 0,
"disable_egg_removal_from_spawner": 1,
"disable_range": 0,
"disable_silk_touch": 0,
"disable_spawner_config": 0,
"disable_speed": 0,
"limited_spawns_amount": 32,
"limited_spawns_enabled": 0,
"monster_egg_drop_chance": 0,
"monster_egg_only_drop_when_killed_by_player": 0,
"disable_specific_egg_drops": {

These are the currently available options in the config, however while there is an option to disable the spawner, or disable the speed, there's no option regarding the actual value of said speed or range.

Drops from breaking spawners can be dropped indefinitely by placing then picking up a spawner

Mods like Paragliders drop items at the breaking of a spawner, even if it's with a silk touch pickaxe; this allows farming of infinite drops.
I don't know if it's feasible, but my suggestion is to alter the tag of the dropped spawner in some manner that doesn't break the vanilla mechanics. If necessary the mods devs will have to implement a check for a tag. but at least there should be something that can be checked

limited_spawns_ebabled was not found

Hey there! on the start of my server the message " [spawnermod/]: Key=limited_spawns_enabled was not found when trying to access it! Returning 0" Is sent about twenty times.

In my config the limited_spawns_enabled is set to 0, as I don't want it enabled.

This may be unrelated but when any player joins, the TPS drops to 1 before crashing with message "server tick took 60 seconds, considering it crashed"

Cows/Mooshroom Cows dont spawn.

Tried on plains and other biomes, however neither spawn using the spawners, I have almost all others working, but not cows? Thanks.

Crashing on a Forge server (in a custom modpack)

@andersblomqvist

Hello, I have an issue with this mod, crash log is https://pastebin.com/MmdiJGBb.

In short, I've investigated the issue, and, based on the string from the log, the part which causes error is this: NBTTagCompound compound = entity.serializeNBT();.
I have some mods which modify mobs, also because this is a server there are other players, so I think that your mod doesn't have a "limiter" and it basically tries to serialize NBT and get spawn egg from every entity.
Also, when looking on the circumstances of the crash, it happened when I've got killed by a Spider. So, I can say that error is caused because mod tries to get NBT and spawn eggs from players, and it shouldn't do this (get those from mobs only).
Thanks a lot if you will investigate this issue and help me (and probably others too) out with it!

Stalwart_Dungeons console spam error

Hi.
Getting a massive console spam with an error:

Key=stalwart_dungeons:spore_projectile was not found when trying to access it! Returning 0.

Can not dig spawner in 1.14.4

I am using this mod on 1.14.4 and everything works except one thing: I can not dig spawner using Axe with Silk Touch. I've noticed the comment in SpawnerEventHandler but I was wondering: are there any plans to fix it somehow? As without ability to move spawners, this mod is very crippled :(

1st Egg of Mob Type Disappears 2nd Egg Sticks in Spawner as Long as Mob Type Does Not Change

Hello! I am on Forge with only a handful of other mods. When I place an egg of a specific mob type in the spawner, it spawns one round of those mobs, and then disappears. The second egg of the specific mob type sticks. If I remove the egg, and use the same egg type again, it doesn't seem to have an issue. It seems to only happen when switching mob types. Example: I put in a blaze egg. Blaze egg spawns one round of blazes, then it reverts back to an empty spawner. I then put in a 2nd blaze egg, and everything works as expected. I believe I then removed and re-inserted the blaze egg and had no issues. I have been getting around this by exiting the game on the first egg, changing my egg drop chances to 100%, and gathering a handful of eggs when I legitimately get the drop.

I am on 1.16.4 with file "branders-spawnermod-1.16.4-1.7.10.jar."

Please let me know if you need additional documentation or testing.

Thanks so much for this mod!

Suggestion: Chunkload support for Mob Spawners?(All versions please)

By default, it seems the Mob Spawners are not compatible with Chunk Loaders, in Vanilla this makes sense, but in a Modded Situation, I wish they were compatible with chunk loaders that way the player didn't have to be in the same area as the mob spawner as long as it was chunk loaded. I kind of see why you wouldn't want to implement this, but it would be a cool toggleable feature to have, like there could be a config like "allow-chunkloading"?

Could not load plugin

Your plugin sounds wonderful. I have been looking for something like this for a while and found your plugin but I am having an issue with loading the plugin. Currently my server is 1.16.5 so I tried every 1.16.5 upload that you have and all with the same issue. I'm getting the following error:

[06:38:49 ERROR]: Could not load 'plugins\fabric-branders-spawnermod-1.16.5-1.1.1.jar' in folder 'plugins'
org.bukkit.plugin. InvalidDescriptionException: Invalid plugin.yml
at org.bukkit. plugin.java.JavaPluginLoader.getPluginDescription(JavaPluginLoader.java:178) ~[patched_1.16.5.jar:git-Paper-786]
at org.bukkit. plugin.SimplePluginManager.loadPlugins(SimplePluginManager.java:160) ~[patched_1.16.5.jar:git-Paper-786]
at org.bukkit. craftbukkit.v1_16_R3. CraftServer.loadPlugins(CraftServer.java:393) ~[patched_1.16.5.jar:git-Paper-786]
at net.minecraft.server.v1_16_R3. DedicatedServer.init(DedicatedServer.java:269) ~[patched_1.16.5.jar:git-Paper-786]
at net.minecraft.server.v1_16_R3. MinecraftServer.w(MinecraftServer.java:1069) ~[patched_1.16.5.jar:git-Paper-786]
at net.minecraft.server.v1_16_R3. MinecraftServer.lambda$a$0(MinecraftServer.java:291) ~[patched_1.16.5.jar:git-Paper-786]
at java.lang.Thread.run(Unknown Source) [?:1.8.0_271]
Caused by: java.io.FileNotFoundException: Jar does not contain plugin.yml

I have 12 other plugins but I don't think it's an interaction problem but if you do, I'll list them if needed. Thank you so much and I am looking forward to using your plugin!

Issues with spawners, possible conflicts with Apotheosis

I added this mod to All The Mods 6 which has Apotheosis present and I noticed some weird things.

  • If I disable silk touch in this mod then spawners no longer drop eggs. If I have it enabled then I get 2 spawners - one from this mod and one from Apotheosis.
    Would it be possible to split 'disable_silk_touch' option into multiple options?
  1. 'disable_spawner_silk_touch' - disables dropping spawner block after silk touching it
  2. 'disable_egg_drop' - disables dropping spawn egg after destroying spawner
  3. 'drop_egg_with_silk_touch' - if this is true then egg would drop only with silk touch, if false then anything will work.
  • Placing spawner that has mob already in it resets mob back to 'area_effect_cloud'.

Changeable lighting level to activate the spawner.

For example, it will work on 0 or 15 (vanilla default value is 11). So it will not be possible turn off spawner for modded big dungeons, or to simplify the exploration of this. And make configurable feature via config file.

Mob Experience Issue

When I place a mob spawner down and put any spawn egg in it the mobs will only drop experience and items for around 1 level up and will then not drop anything no matter how many are killed by me unless I reopen the game.

"disable_silk_touch": 1 does not seem to work.

Spawners are still dropping even with disable_silk_touch set to 1 in the config. Disabling this mod makes them stop dropping, so it's definitely something with this mod.

For reference, I'm running the latest Minecraft v1.18 version of the mod, downloaded from Modrinth.

Placing egg in spawner too quickly results in one spawn then lost egg

I can reproduce this issue in a fresh save on Minecraft version 1.16.4, Forge version 35.1.35, Enhanced Mob Spawners version 1.16.4-1.7.9, no other mods.

If a spawner is placed and then an egg is used on it immediately, before the spawner has a chance to "spawn" an empty cloud, then the first spawn will spawn the mob but also revert the spawner to empty, without dropping the spawn egg. Placing a spawner, waiting for the red cloud to pop, then adding the egg results in the spawner retaining its egg throughout spawns as intended.

Upload new versions to Modrinth

Hi! I saw that the new 1.19 versions were available on CurseForge but not on Modrinth yet. Do you have any plans to add the new releases to Modrinth? I am working on a Modpack management script that takes advantage of Modrinth's awesome API, and definitely would appreciate if the new versions were available there too.

Thanks so much!

[BUG] incompatible with companion mod + no creative spawner

So I've got 2 things here, for the first one after searching for a couple hours and finally spawning it in with a command, I can say with absolute certainty that there is 100% not a spawner added to the creative menu. It simply isn't there. For the second one this mod seems to be incompatible with companion mod (tents and camping) with both mods installed when I try to craft the key it doesn't work, but weirdly when I go to take the ingredients and put them back in my inventory they dissappear completely, and the disappearing ingredients bug happens when I try to craft anything in the game. Anyway I'm on fabric 1.18.2, also love this mod, super cool ๐Ÿ˜Š

Console log erros and spawner gets cleared

Describe the bug
Spawner get cleared and a lot of spam in console

To Reproduce
Steps to reproduce the behavior:

  1. Go to the nether, find a blaze spawner and mine it with silk touch

  2. you get the actual spawner twice, an empty and one with 'minecraft:blaze'

  3. place it in the overworld,

  • a. place a lever on it and flick it on. now the spawner contains 'Area Effect Cloud'
  • b. apply any other item, such as sugar, clock or fermented spider egg. the spawner contains 'Area Effect Cloud'
  1. the console get spammed with logs (see Logs/crashlogs/etc)

Logs/crashlogs/etc
https://pastebin.com/q6caiixN

Expected behavior

Screenshots
none

Minecraft enviroment (please complete the following information):

  • OS: windows (client) / Linux (Server)
  • Ram allocated pc: 8gb, server: 8gb
  • Minecraft & Forge version: 1.15.1 - 30.0.36
  • Mod Version: v1.4.4

Additional context

Suggestions

Here are some ideas for functions/options that would be nice to have,

Options/Function:
Add Disable required Player //That mobs can spawn even there is no player within 128 block or even on another dimension
Add Disable spawn requirements //That mobs can spawn even there is light or water
Add Increase/Decrease MaxNearbyEntities
Add Disable spawn egg drop for Mobs spawned by spawner or spawn egg

Possible items that can be used for the options above:
Dragon Egg
Nether Star
Enchanted Golden Appe
Ghast Tear

Additional ideas:
Add the number of entities in the GUI for SpawnCount <number of entities to spawn> like SpawnRange (same for Speed would be nice)

Inconsistent interaction with redstone

Issue: Spawners have to be hard powered (Level on block, repeater pointed into the block) to be disabled. If you hard power the spawner and then soft power it (lever attached to the block next to it or a redstone block next to it) and then remove both redstone sources the spawner remains off, even though no redstone power has been applied.

Request: Make the spawners interact with redstone like pistons or other redstone devices, that way they don't have to be hard powered and their interactions are predictable.

Alex's Mobs, Better Nether & Better End issues with config

The config auto populate for spawn eggs is having issues with these three mods and is only populating a portion of the item name/mob name.
https://gist.github.com/judicius96/6ac3d44b7c2dcd2f24210fe2e97586bc

When I attempt to manually correct or add the 20+ missing mobs from alex's mobs the mod says the partial entries are missing and "fixes" the config file.

If i turn the egg drop rate to 100% and kill a creature not listed (alex's mob emu for example) there's a console message saying the creature doesn't exist to drop egg.

Forge 36.2.34
Pack Builders Delight 2 version 3.7.2
Spawner Mod Version 1.8.14
Minecraft 1.16.5

Conflict with fabric mod "Custom Spawns [Fabric]"

When both mods are installed together, any changes made to a spawners settings via the Spawner Key will reset to the default when the spawner next activates.

Disabling a spawner with redstone also doesn't work, The spin animation will stop but the spawner will still spawn mobs.

EMS is using Overwrite mixins when injects is sufficent.

Hello! Someone on curseforge was showing that EMS crashes with other mods and the error looks like conflicting coremods. I took a look and it seems you are trying to patch this Mojang bug like a lot of other people are trying to do as well: https://bugs.mojang.com/browse/MC-189565

However, when I look at the mixins that EMS does, it seems it uses an Overwrite mixins which is highly discouraged as overwrites are strictly not compatible with any other mixin and will crash anyone else trying to fix this bug.
https://github.com/andersblomqvist/enhanced-mob-spawners/blob/master/src/main/java/com/branders/spawnermod/mixin/EndermanEntityMixin.java

Instead, I would encourage you to take this mixin Draylar gave me which uses an Inject mixin to solve the bug but also allows other people to do inject mixins as well without crashing each other. This would be the most mod compatible way of solving this issue.
https://github.com/TelepathicGrunt/RepurposedStructures/blob/master/src/main/java/com/telepathicgrunt/repurposedstructures/mixin/EndermanSpawnerMixin.java

I hope this helps! I can explain how the Inject mixin works if you need me to.

Passive mobs do not spawn in mushroom biome

I tested this in mushroom biome with sheep, chickens, pigs, and mooshrooms. Of those, only the cows spawned, the sheep, chickens and pigs did not. Hostile mob spawners work as expected.

I'm running Fabric under 1.18.1 and the mod with the latest versions at the time of reporting. Thanks.

Toggle spawn egg drops from spawner mobs

Seems like it would be good for balance to make it possible to toggle spawn egg drops and maybe edit drop rate from spawner mobs independently of regular mobs. Once you get a spawner going the egg drops from those mobs make the eggs much more common.

Feature Request: Configurable blacklist for right click interaction with spawners

Hi! This is a suggestion for the 1.18.2 version of the mod.

At FTBTeam/FTB-Modpack-Issues#1221 a user noticed a compat issue between Soul Shards and Enhanced Mob Spawners.

If a player holds a Soul Shard and right clicks a spawner with Enhanced Mob Spawners, it kind of bugs out. My suggestion would be to have a blacklist by item id within Enhanced Mob Spawners to be able to prevent some held items to "pop" the spawn egg out of the spawner. I assume this would allow normal interactions between the spawners and the other mods, such as Soul Shards.

Here's a small video explaining the issue and why I'm suggesting this change (souls are being duped, normally the spawner is consumed in the process):

soul_shard.mp4

Thanks for reading and have a nice day!

Spawn egg drop changes

Can you add a config option to disable spawn egg drops unless the player killed the mob? This way, automatic mob farms don't generate tons of spawn eggs.

Could you also add an enchant that makes it so spawn eggs don't drop, so that mob farms don't drop a lot of eggs that you have to store or recycle back into the system.

[Bug]: Mobs still spawning even with redstone to spawner

Steps to Reproduce the Bug

Iron golem spawners turned off by redstone yet still spawning iron golems.

Enhanced Mob Spawner filename

spawnermod-1.18.2-1.8.17+Forge

Other mod filename (Optional)

minecraft 1.18.2, forge 40.1.85

Extra Notes (Optional)

No response

[1.16.3] Log Spam with specific Spawn Eggs

Hi,

I really like your mod because I like the feature to "capture" a mob spawner and place it where I like it without being overpowered at all. But there is a bug in minecraft (not your mod) and I hope you can help to fix this until Mojang releases 1.17.

The problem is within minecraft when you use a specific spawn egg on a vanilla spawner with mobs which can be angered. Then Minecraft produces a ton of messages and spam your log.

The following spawn eggs are affected:

  • Bee Spawn Egg
  • Enderman Spawn Egg
  • Polar Bear Spawn Egg
  • Wolf Spawn Egg
  • Zombified Piglin Spawn Egg
  • Iron Golem Spawn Egg (from your mod)

I'm using:

  • Minecraft: 1.16.3
  • Forge: 34.0.9
  • Branders-Spawnermod-1.16.3-1.6.6

Possible Solutions:

  • Enable/Disable specific Spawn Eggs?
  • Enable/Disable specific Mob from dropping their spawn eggs?
  • Implementing the code from Draylar in your mod?

Sources:
Minecraft Bug Tracker

A Fabric Mod that fixes the problem:
Angerable Patch

Maybe you have other ideas for a workaround?

I'm happy to hear from you :-)

[REQUEST] Make this mod Server-side only type.

Remove key, replace it with vanila stick (or even something you can specify in config, nether star, emerald or something like this).
Make so this mod can be installed on server without need to be installed on client to join.

Modded spawners sometimes don't drop spawn eggs + redstone

Hi!

I've played around with it a bit in 1.18.2, and it's pretty cool. I was wondering about some inconsistencies sometimes with spawn eggs from spawners. For example, normal vanilla spawners work as intended, although some modded spawners like the ones that can spawn "Bloviators" from Cloud Storage will drop an empty spawner and no spawn egg.

I think this may be due to their naming convention (spawn_egg is placed before):
image

I was wondering if there is something you could do for those cases. Or else, would it be possible to code the spawners to drop with their configuration as an item (not dropping any spawn eggs)? Possibly this could also be a toggled feature in the configuration file, just an idea.

As well I've noticed a quirk with redstone, it looks like this does not work (the spawner does not turn off):
image
Any directly adjacent redstone does work though.
Perhaps this is linked to an old issue, #32?

Thanks in advance!

-Versions-
Minecraft 1.18.2
Forge 40.1.20
Enhanced Mob Spawners spawnermod-1.18.2-1.8.15+Forge.jar
Cloud Storage cloudstorage-1.1.0-1.18.2.jar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.