anders429 / hashable_rc Goto Github PK

I want to be able to iterate over the (key, value)'s of a HashMap in which the key is a HashableRc, but with HashableRc I cannot get the original Rc back. Since HashableRc holds a clone of the Rc, it would be trivial to add a get_cloned() method to HashableRc for my use case. What do you think? Would you be agreeable to a PR?

by_address is a far better implementation of this, providing hashing by address to any pointer type. While it doesn't provide it for Weak, that's probably for the better, since in retrospect the hashing via address on Weak is unsound anyway, as it doesn't follow the rules required for a type to implement Hash, as the pointer location is variable even when the Weak pointer is not itself mutated.

The following steps should be taken to correctly deprecate this crate:

• Add notice to README about deprecation, pointing to the suggested by_address crate as an alternative.
• File a RUSTSEC notice for the crate no longer being maintained.
• Publish a new version of the crate with the deprecation warning. This should only have the README and possibly a message informing the user of the deprecation.
• Yank all the old publications. I think this is necessary since the Weak wrapper isn't actually sound.
• Archive the repository.