anandundavia / thanos-js Goto Github PK

• logger.warn() is exported as console.log() instead of console.warn()
• Code:

    lib/Utils/logger.js
    module.exports.log = (...msg) => console.log(...msg);
    module.exports.warn = (...msg) => console.log(...msg); //TODO: console.warn(...msg)

What happens when there are odd number of files? Will it leave the odd file as it is or will it wipe out half of its contents?

Probably not worth the time considering what the program does but,

It seems like just doing a random number for every file will allow less than half or more than half depending on the randomness.

Should be a check to ensure exactly half occur.

Could assign a value at random to every file and then only take the top 50%.

After using this package I immediately pushed code to the production, now as I can see, my PM is looking for me with an axe in his hands. Is it normal behaviour or should I need to use this library in any other way?
If this is an issue from the library, I expect this issue to be fixed ASAP.

Can we get this as a nuget package?

need to restore back the deleted files at the exact same place and time that it was deleted.

Marvel created the universe.
The universe contains planets.
Planets (sometimes) contains beings (characters).
Thanos did not cut half of the universe itself.
Thanos did not cut half of the planets itselves.
Thanos did snapped half of the beings.
Thanos.js is cutting half of the files, not the characters of these files.

that would be kinda evil, the Thanos way 😄

README.md states:

He will wipe out about one third of your files if he snaps fingers without gauntlet. And If he has the gauntlet, he will crush about half of them.

However, the following line actually wipes out about one quarter of your files if he snaps fingers without gauntlet.

Half of my files in node_modules got detroyed!