amy-lei / fish Goto Github PK

Right now, it assumes the user was an original player and does not account for outsiders trying to join an ongoing game.

chat, roomkey name

• Although it is the fault of the player for not paying attention, this becomes hacky when the cards are within a team but declared incorrectly. No way to prevent this.

• Backend player data does not reflect front-end data
• Index appears as null for rejoined player

• After successfully guessing a card, the card does not appear in the game view, although it is a part of the state (as seen in the ask view)
  • Perhaps because ViewHand is not connected to the store

• Because we rely heavily on socket events and they're placed in componentDidMount(), props from the redux store are often registered as null. This causes a lot of issues down the line, and we have resorted to hacky solutions before. Let's not accumulate any more technical debt!

It says "undefined has joined the room"

Lots of repetitious code involving creating mini cards, etc. Same with classNames.

• Uncertain about the exact cause but something caused the cards to go undefined

How can we maintain the order of the cards on the frontend without having to duplicate what the backend already did?

The cap of 6 players is not enforced in the waiting room!!!

Idea: Larger selection but random, and persist order throughout game?
Idea: Have the user select from pool of options then have it persist in db?

Right now, it is a hardcoded list with the same order every time. Hoping to expand this.

• The team colors are correct, but the labels are sometimes wrong

Currently annoying to backtrack

• Doesn't properly display "__ of __" sometimes
  EDIT: occurs in the respond view

• In the real game, this is a big influence on who to ask cards from or who to declare about

Right now, its designed is 100% based off of a Macbook Pro.
It is especially NOT mobile friendly.

• Notify players when someone disconnects so they are aware
• Get the player back in the game with the correct info
  • Make sure backend is always up-to-date with data on front-end
• At the same time, prevent players who weren't originally in the game from joining

• Bring tooltip to highest possible z-index

The game does not take account of the case where the player whose turn it is supposed to be ends up being out. Leaves the game unplayable.

Dont wanna bloat our db and limit the possible keys.
Maybe when theres a collision in key, check if there are any players? This also means we need work on disconnecting users when they leave.