amithash / trsh Goto Github PK

What steps will reproduce the problem?

[02:30 PM] root@yew :: /usr/bin $ ls -l python
lrwxrwxrwx 1 root root 7 Sep 29 12:03 python -> python3
[02:31 PM] root@yew :: /usr/bin $ rm python
Use of uninitialized value $success in numeric eq (==) at /usr/scripts/trsh 
line 855, <IN> line 11.
Use of uninitialized value $success in numeric eq (==) at /usr/scripts/trsh 
line 855, <IN> line 11.
Use of uninitialized value $success in numeric eq (==) at 
<repeats forever>

What version of the product are you using? On what operating system?

TRSH VERSION 3.15-2 on Arch linux.

Please provide any additional information below.

Haven't seen this happen before, and I use trsh constantly. Is there a logical 
reason why $success could be initialized?

 Are you going to modify/improve this utility? For instance, to alert when 
a non-empty directory is going to be removed (like in the regular ‘rm’ 
command)?  

These are just some thoughts on using on OS X. I do not think it is
possible or recommended to use existing Trash folder.

I changed ".local/share/Trash" to "./Trash" as per OS X.

rm --list does not show existing trash (since trsh reads from its own repo).

Deleting a file caused an endless loop in line 805.
                $success = sysopen INFO, "$infodir/$infoname", 
O_RDWR|O_EXCL|O_CREAT;

I think this is because folders info and files does not exist. So i created
these from Terminal and touched the metadata file.

Now I am able to "rm" a file, and see result. However, of course, any file
deleted in Finder will not show up using rm.

Also, if I use the "Empty" button from Finder, then the metadata folders
and files I have placed in Trash will get erased.

Further thoughts:

1. Place metadata info in a separate location, so Empty does not remove it.
(should be configurable, so other Unices not affected).

2. Why does "rm" not display files in trash. Why from metadata only ?

3. In OSX, i don't think original dir structure is maintained. So if you
want to restore a file, you drag it where you want it to go. trsh remembers
where it came from, so that's why it uses metadata (i guess).

All in all, I think it's okay to continue to use a separate structure such
as ".local/share/Trash". If someone just wants to use existing Trash, then
rm can be aliased to a "mv" which is all that existing Finder delete does.

What steps will reproduce the problem?
 explained above

What version of the product are you using? On what operating system?
OS X 10.6.3. Snow Leopard. Bash shell.

Please provide any additional information below.

please add revision number to README file

What steps will reproduce the problem?
1. ln -s <directory> <symlink>
2. trsh <symlink>

What is the expected output? What do you see instead?

It should work. Instead, I get:

trsh: cannot remove `/path/to/symlink': Is a directory

What steps will reproduce the problem?
1. trsh -l

What is the expected output? What do you see instead?

It should list the files in the trash. Instead, I see:

$ trsh -l
Use of uninitialized value $_[0] in substitution (s///) at 
/usr/share/perl5/core_perl/File/Basename.pm line 341, <IN> line 103.
fileparse(): need a valid pathname at /usr/scripts/trsh line 776.

What version of the product are you using? On what operating system?

Latest git commit (July 4th, 2012).

What steps will reproduce the problem?
1. trsh -e

What is the expected output? What do you see instead?

I expected to see some kind of summary of what I'm about to delete Ideally, a 
list of the files ("trsh -l"), but I'd settle for "Delete 371.3 MB of files? 
(y/n)".

What version of the product are you using? On what operating system?

The latest, on Linux.

What steps will reproduce the problem?
1. Install trsh on Ubuntu 12.04, 
2. Restart shell,
3.

What is the expected output? What do you see instead?
rm must be aliased to /usr/bin/trsh.pl, but /etc/bash.bashrc is not touched.

Please use labels and text to provide additional information.

What steps will reproduce the problem?
1. touch file\$name
2. trsh file\$name

What is the expected output? What do you see instead?

File should be deleted.

Instead, I see:

mv: cannot stat `<path>/file': No such file or directory
Recovering from failed delete

There is now an entry in the trash, AND a file still on the drive.

I'm a little afraid of emptying the trash with trsh -e. :)

What version of the product are you using? On what operating system?

TRSH VERSION 3.11-0
Ubuntu Maverick

What steps will reproduce the problem?
1. Make a broken symlink
2. Try to delete it

What is the expected output? What do you see instead?

It should be deleted.

What version of the product are you using? On what operating system?

The latest one on Linux.

Please provide any additional information below.

[07:49 PM] epi@fizz :: ~ $ ln -s nonexistant-file x
[07:50 PM] epi@fizz :: ~ $ rm x
trsh: delete write-protected regular file `/home/epi/x'? (y/n): No! It is a 
broken symlink!         
trsh: delete write-protected regular file `/home/epi/x'? (y/n): NO!
trsh: delete write-protected regular file `/home/epi/x'? (y/n): N
trsh: delete write-protected regular file `/home/epi/x'? (y/n): fgsfds^C    
[07:51 PM] epi@fizz :: ~ $ /bin/rm -rf x
[07:51 PM] epi@fizz :: ~ $        

What steps will reproduce the problem?
1. trsh filename

What is the expected output? What do you see instead?

It should delete the file.

Instead, it says: 

Use of uninitialized value $mnt in -w at trsh.pl line 1007, <IN> line 17.

What version of the product are you using? On what operating system?

TRSH VERSION 3.11-0
Ubuntu Maverick

Please provide any additional information below.

A patch that fixes the bug is attached (a very crude one, but it works!)

What steps will reproduce the problem?
1. Run rm --list

What is the expected output? What do you see instead?
Expect to just see listing of filenames
I get an error as:
Argument "57+05" isn't numeric in int at /Users/rahul/.trsh.pl line 1646,
<IN> line 10.


What version of the product are you using? On what operating system?
trsh.pl 3.11-0
Mac OS X Snow Leopard.

Please provide any additional information below.

 I've added a line to remove "+TZ" after the ttime assignment.

$ttime =~ s/\+.*//g;

After this line, its okay.

I suggest you add instractions for the manual installation of the script 
(as you did in previous releases)