amdelamar / jotp Goto Github PK

Skip the install step like so:

before_install:
 - chmod +x gradlew

install: echo "skipping install step"

script:
 - "./gradlew check"

The default install step runs gradle assemble. So doing that AND gradle check isn't really useful when tasks are being repeated on every build.

See https://gradle.org/whats-new/gradle-5/

Currently com.github.amdelamar does not match the actual package com.amdelamar used.
This should be updated so it can be published to maven central.

Hi,

Firstly thanks for the awesome library!

I'm not sure if you are aware but JCenter is shutting down https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter

I can't imagine what this means for Android ecosystem etc who heavily use Jcenter

Anyways perhaps it's worth looking at publishing releases to another repository as well?

They should check more than null

The latest published package is not mirrored in JCenter for some reason.

https://bintray.com/bintray/jcenter/jotp

https://bintray.com/amdelamar/mvn/jotp

Might be because of the group id change.

First you'll need to generate a pom.xml

Then update maven/gradle instructions:

Gradle:

repositories {  
   jcenter()  
}

Maven:

<repositories>
    <repository>
        <id>bintray</id>
        <url>http://jcenter.bintray.com</url>
    </repository>
</repositories>

Default is 30, but we should allow changing the period to other values.

If I am not wrong it uses the challenge response,HMAC-SHA128
Do i need some other 3rd party lib driver code to obtain the response then feed to jotp lib or is it included like the full spec?

com.amdelamar.jotp.type.TOTPTest > totpTests FAILED
    org.junit.ComparisonFailure at TOTPTest.java:50

Most likely because the test triggered late within the 30 second window.

// this generated code
OTP.create("MFRGGZDFMZTWQ2LK", OTP.timeInHex(), 6, Type.TOTP)

// does not equal this code
OTP.create("mfrggzdfmztwq2lk", OTP.timeInHex(), 6, Type.TOTP)

Secret should always be uppercased.

plugins {
  id "org.sonarqube" version "2.6"
}

./gradlew sonarqube \
  -Dsonar.organization=amdelamar-github \
  -Dsonar.host.url=https://sonarcloud.io \
  -Dsonar.login=xxxxxxxxxx

https://sonarcloud.io/projects

See all the issues by running:

./gradlew javadoc