Code Monkey home page Code Monkey logo

chartr's People

Contributors

amanharwara avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

chartr's Issues

Low quality images on Itunes Search Provider.

Describe the bug

In this bug, the images that are provided on the iTunes search provider are in low quality. This is only exclusive for the itunes search provider, the images on the other search providers are in good shape.

To Reproduce

  1. Set the search provider into Itunes
  2. Search any album and click on image

Expected behavior

I was expecting the image quality to show up in great shape.

Screenshots

image

Information:

  • OS: Windows
  • Browser w/ version: Brave

complete lock of the site on startup?

When I open the website, it is completely unresponsive. Changing values like the padding or font doesn't do anything, and all buttons are unresponsive. Could it be because I'm using firefox? please help

Missing albums covers on topster when downloaded

I made a topster using Chartr and it worked fine on the website itself. I expected it to look the same when I saved the image. However when I downloaded the topster as a PNG, the image did not show most of the album covers. Two of them showed up just fine but the other 62 albums did not have covers. They just showed the title (I had titles turned off) and the little PNG icon, then an empty space. I tried multiple times after but the problem was the same.

To reproduce it, just make an topster with 64 albums and use the settings I used here. Then click "download". Image below is a screenshot of the website.
image
Now here is the PNG I got from clicking "download".
image

OS: Windows
Browser: Chrome Version 103.0.5060.66 64-bit

Remember, the website itself shows the album covers just fine. They are only missing on the image I download.

Exposed Lastfm API key

Describe the bug

When Last.fm is selected as the search provider, the browser sends queries directly to Last.fm with Chartr's API key.

Expected behavior

The Last.fm requests should be routed through your own server to hide the API key. I see you're using a Heroku app for CORS proxying, so it would be a relatively minor bandwidth commitment to make it handle Last.fm requests too. This would also allow you to implement a caching system to reduce the chances of hitting Last.fm's request limit (4 per second, if I remember correctly).

Other

You are likely to see a big increase in traffic soon, if you haven't already. Topsters 2 appears to be on the verge of shutting down. I run the other major open-source topster site, https://github.com/camdendotlol/topstersorg, and the past few days have brought 2-3000 hits/day. My backend is closed-source for now, but I'd be happy to share snippets from my load balancing, caching, and proxying routes if it helps.

iTunes Search Provider Error

Describe the bug

Whenever I search for an album using iTunes as the search provider, nothing comes up.

To Reproduce

  1. Set iTunes as the search provider

  2. Type anything into the search box.

Expected behavior

No results.

Information:

  • OS: Windows
  • Browser w/ version: Chrome 108.0.5359.99

Importing .json from Topsters causes app to (permanently?) lock

I was curious (and was hoping I could get away with not having to remake my whole chart) and tried to upload my .json backup from Topsters. Doing this caused all the buttons to stop working entirely, and even going as far to clear my cookies and cache doesn't seem to fix the issue. I know expecting the .json file to import was a bit of a pipe dream, but there should be some way to reset the app entirely, especially in these early stages where locks like this can happen.

Tier list convenience

I am not sure if you are still working on this project but if you are, making it easier to change the position of albums in the same tier (left to right) in the same way you did it for up and down would be really convenient. Also adding, deleting, and renaming tier names. Thank you! Apologies if this is filed under the wrong area

Discogs images not rendering in downloaded chart

Describe the bug

Downloading an image that uses album art derived from Discogs.com results in them not rendering in the chart.

To Reproduce

  1. Switch search provider to Discogs.
  2. Insert an album art.
  3. Download the chart.

Expected behavior

The photos sourced from Discogs should render in the chart; however at present moment they do not, instead showing a "picture not available" thumbnail instead.

Screenshots
Topmost image is iTunes, secondmost is Discogs, thirdmost is Last.fm.

Untitled Chart (1)

Information:

  • OS: Windows 10
  • Browser w/ version: Chrome 97.0.4692.71

Enhancement: automated collage sort based on artist name / album name

This is something that I was thinking of adding because I feel like it'd be useful to an end user. I remember trying to sort both through the GUI and through the arrow keys and it had some usability issues that prevented me from enjoying the experience.

I was thinking we could have a button (maybe in Chart Options) which runs a function which flattens the album list array, sorts the album list array via artist name first and album name second (if by artist) or just by album name (if by album), and then unflattens it so we can sort the collage in order. Perhaps there is a better implementation of this, but this was my gut feeling just seeing some of the code. I'd appreciate your feedback - not sure how useful this would be to others.

Here's a quick mockup:

Before pressing Sort by Album:
Before pressing sort by album

After pressing Sort by Album:
After pressing sort by album

Certain albums causing a soft-lock

When I attempt to add certain albums to my chart (The first I noticed this with was Static-X - Project Regeneration, Vol. 1; at least one other has caused the same bug), the album will not load in and then all buttons/sliders stop reacting to clicking The search bar stops accepting input, nothing works. Bug is resolved upon refreshing the page, but it happens consistently with these specific items.

The other albums I've found causing the same issue are Wayne Static - Pighammer and Tyler, the Creator - IGOR, though I'm sure there are plenty more with the same problem.

"Gap Between Items:" value resets between visits when set to 0. (also "Padding:" value but that doesn't offically support 0 but should)

OS: Windows 10
Browser: w/ version: Firefox 94.0.1

If you leave the site with the "Gap Between Items:" value set to 0, when you return the value will be set to 5. This does not affect loading/exporting chart backups. The same issue also applies to having the "Padding:" value set to 0, being set back to 7 instead, but that is not officially supported (but should be).

On backup load or fresh creation:
image
After page refresh:
image

json:
test-backup.txt

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.