Code Monkey home page Code Monkey logo

alvarcarto-designer's People

Contributors

kimmobrunfeldt avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar

Forkers

thanos971

alvarcarto-designer's Issues

When having two different size maps, the moving one causes the other one move also

Steps to reproduce

  1. Add poster
  2. Change the currently selected poster's (cartItem no. 2) size
  3. Move the map up
  4. Switch back to cart item 1
  5. It has now moved also.

alvar

What is happening

So the bug is something like this:

  • Setup the situation (2 maps different sizes). We're now editing the first cart item.
  • Switch to the other map (cart item #2), which causes our app to mark that we're editing number 2
  • Map starts to resize and move to the location of what #2 should be
  • While moving to the correct location, map sends a change event
  • Our app saves the middle way to cart #2, which makes it move to the incorrect place

I couldn't reproduce this bug if the other map is from far away, so it apparently only happens when the two maps are from close locations which causes the map to animate the position change instead of a complete reload of the map

Search field is bad UX

A few users gave comments that this behavior was bad UX:

alvar2

The search field should either select the Oulu text, or clear it but it felt buggy that cursor goes to the beginning.

Execute browser testing

  • Chrome Version 57.0.2987.133 (64-bit) on OS X 10.10.5
  • Opera 43.0.2442.1165 on OS X 10.10.5
  • Firefox 49.0.2 on OS X 10.10.5
  • Safari 10.1 on OS X 10.10.5
  • IE9 (should show unsupported message) BrowserStack
  • IE10 (should show unsupported message) BrowserStack
  • IE11 on Windows 8.1 BrowserStack
  • Edge 14 on Windows 10 BrowserStack
  • Safari 8 on Yosemite BrowserStack FAIL: Layout breaks -> Fixed with autoprefixer config change
  • Safari on iOS 8 iPad 2 FAIL: Layout breaks -> Fixed with autoprefixer config change
  • Safari on iOS 8 iPad Mini 3 FAIL: Layout breaks -> Fixed with autoprefixer config change
  • Safari on iOS 9.3 iPad Mini 4 FAIL: Credit card number validation fails sometimes but layout works -> Fixed with Stripe v3 JS lib update (Elements)
  • Safari 9.1 on El Capitan BrowserStack FAIL: Credit card number validation fails sometimes -> Fixed with Stripe v3 JS lib update (Elements)
  • Android 4.4 Chrome on Samsung Galaxy S5
  • Safari on iOS 10.1.1 iPhone 6

Test sequence:

  1. Search for "Helsinki"
  2. Select 50x70cm
  3. Select landscape
  4. Toggle labels off
  5. Toggle labels back on
  6. Write "My Helsinki"
  7. Write "South Finland"
  8. Go to checkout
  9. Add new Poster
  10. Go to checkout again
  11. Finalize checkout

Finalize set of styles

  • Road map
  • Dark map
  • Single color map (Orange)
  • Antique
  • More wacky art (e.g. red parks etc)

Fail-safeties to ordering

  • Write fail log to failed_orders
  • In the error message, guide how to ask refund
  • Should we do our internal order first, then charge payment? edit: decision: no
  • Save bounding box coords to stripe meta data

Global state and map view falls out of sync

Test case:

  1. Open vector map and set pitch / rotation to something
  2. Open raster map
  3. Open another vector map again

Expected result: pitch and rotation would be the same as set in 1.
What happens: vector map doesn't take the initial pitch / rotation into account when redrawing the map.

Error when searching a city

Unhandled rejection TypeError: Cannot read property 'long_name' of undefined
    at findCityFromGoogleObject (webpack:///./src/components/GeoSearch.js?:159:5)
    at googleObjectToResult (webpack:///./src/components/GeoSearch.js?:135:11)
    at eval (webpack:///./src/components/GeoSearch.js?:103:30)
From previous event:
    at Object._onChange (webpack:///./src/components/GeoSearch.js?:102:67)
    at Object.setValue (webpack:///./~/react-select/lib/Select.js?:654:14)
    at Object.eval (webpack:///./~/react-select/lib/Select.js?:675:12)
    at CallbackQueue.notifyAll (webpack:///./~/react-dom/lib/CallbackQueue.js?:76:22)
    at ReactUpdatesFlushTransaction.close (webpack:///./~/react-dom/lib/ReactUpdates.js?:59:24)
    at ReactUpdatesFlushTransaction.closeAll (webpack:///./~/react-dom/lib/Transaction.js?:206:25)
    at ReactUpdatesFlushTransaction.perform (webpack:///./~/react-dom/lib/Transaction.js?:153:16)
    at ReactUpdatesFlushTransaction.perform (webpack:///./~/react-dom/lib/ReactUpdates.js?:89:32)
    at Object.flushBatchedUpdates (webpack:///./~/react-dom/lib/ReactUpdates.js?:172:19)
    at ReactDefaultBatchingStrategyTransaction.closeAll (webpack:///./~/react-dom/lib/Transaction.js?:206:25)
    at ReactDefaultBatchingStrategyTransaction.perform (webpack:///./~/react-dom/lib/Transaction.js?:153:16)
    at Object.batchedUpdates (webpack:///./~/react-dom/lib/ReactDefaultBatchingStrategy.js?:62:26)
    at Object.batchedUpdates (webpack:///./~/react-dom/lib/ReactUpdates.js?:97:27)
    at dispatchEvent (webpack:///./~/react-dom/lib/ReactEventListener.js?:147:20)

screenshot 2017-01-15 00 05 04

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.