altrive / pscodeanalyzer Goto Github PK

View Code? Open in Web Editor NEW

12.0 12.0 1.0 684 KB

PowerShell code analysis module

License: The Unlicense

Shell 0.07% PowerShell 2.87% C# 97.06%

pscodeanalyzer's People

Contributors

Stargazers

Watchers

Forkers

c0ns0le

pscodeanalyzer's Issues

Code format error when multiple PowerShell console tab is opened

Steps to reproduce problem

Open PowerShell ISE
Press Ctrl+T to open new PS tab
Move to defaull PS tab and Press Ctrl+K,Ctrl+D

Escaped space characters is not retained after code formatting

Escaped space characters is not retained after code formatting operation.

Example

#Before format
"1" + `   + "1"
#After format
"1" + + "1"

PowerShell buildin tokenizer doesn't return escaped space characters（` ）.
If this problem cause wrong formatting result case, it may need to fixed.

Error occured when using begin/end blocks without process block

begin
{
    function Func1{
        Write-Host "def"
    }
    function Func2{
        Write-Host "ghi"
    }
}

Write-Host "abc"

end {
    Func1
    Func2
}

Non PowerShell code formatting.

Need to check extensions before code formatting.

Error when execute code formatting operation under debug context.

Error dialog appeared when hit break point condition on code formatting operation.

example:

Get-PSBreakpoint -Variable StackTrace | Remove-PSBreakpoint
Set-PSBreakpoint -Variable StackTrace -Mode Write -Action {
    Write-Host "error!!!!"
} > $null

ISE editor crash is some condition

ISE randomly crashed when Ctrl+K,Ctrl+D formatting.
There seems to be exist some text pattern that cause this problem.
but it can't reproduce in unit test environment, only occures ISE environment.

ISE crashed when use Enter-PSSession

When execute following command, ISE crashed.(Crash dialog appeared)
Need to handle remoting events?

Enter-PSSession localhost

Error occurs when code contains PSv4 DynamicKeyword statements

User defined DynamicKeyword token is not recognized appropriately after code formatting.

#Requires -Version 4.0
Set-StrictMode -Version Latest

#Reset Existing Dynamic Keywords
[Management.Automation.Language.DynamicKeyword]::Reset()

#Add Dynamic Keyword
$keyword = New-Object System.Management.Automation.Language.DynamicKeyword
$keyword.Keyword = "requires"
$keyword.BodyMode = [Management.Automation.Language.DynamicKeywordBodyMode]::ScriptBlock
$keyword.NameMode = [Management.Automation.Language.DynamicKeywordNameMode]::NoName

[System.Management.Automation.Language.DynamicKeyword]::AddKeyword($keyword)

function Test
{
    param (
        $aaa,
        $bbb
    )
    $ccc = "ccc"
    requires
    {
        1 | should be 1
        1 | should be 2
    }
}

function requires
{
    param (
        [Management.Automation.Language.DynamicKeyword] $KeywordData,
        $Name,
        [ScriptBlock] $Value,
        $SourceMetaData,
        $InstanceName
    )
    #$PSBoundParameters
    $ErrorActionPreference = "Stop"
    try
    {
        return & $Value #Execute ScriptBlock
    }
    catch
    {
        Write-Host ("Error Line: {0}" -f $vvv.InvocationInfo.Line.Trim())

    }
}

Test

Align statements when using if statement with return values

Example

$result = if ($false)
          { "abc" } else  #True
          { "def" }       #False

Ref: https://connect.microsoft.com/PowerShell/Feedback/Details/53059

Improper left paren formatting after variable.

Currently, LParen placed after variable is handled as function call.
and space is removed.

Join-Path $env:TEMP([Guid]::NewGuid())

should be

Join-Path $env:TEMP ([Guid]::NewGuid())

Indent BlockComment appropriately

Current implementation only indent multiline comment first line.
Need to indent other lines.

Formatting result corrupted, when unmatched quoted string exists

It cause corrupted strings literal (spaces inserted after double-quote start)
and can't detect token validation errors after code format.

It should not format source code when specific parse error found.

IsDirty flag is marked after code formatting even if no effective change exists

In some case, editor's IsDirty flag is marked after code formatting operation even if no effective change exists.
This problem is caused when token is replaced with same token.
If replaced token is identical. Need to be skip replace operation.

Error when multiline comment exists between expressions

Executing formatting following statement throw errors.

$(1..100)<##>.<##>Where({ $_ % 4 -eq 0 })

Format code operation failed! Please report following error context information
---------------------------------------
Line: Before -> After
$(1..100)<##>.<##>Where({ $_ % 4 -eq 0 })
$(1..100) <##>.<##>Where({ $_ % 4 -eq 0 })
---------------------------------------