alterego-labs / betfair_api_ng_rails Goto Github PK

Empty array not carry information about occurred error.

Move reading yaml file and setting up config options to BetfairApiNgRails::Config file.

e.g.,

Add ":market_ids" to the MARKET_FILTER_ATTRIBUTES in lib/betfair_api_ng_rails/api/data/market_filter.rb

Extract all result hashes to additional configuration file (maybe yaml).

This issue is coupled with #18.
At best, defining attributes must looks like this:

class EventResult
  attribute :event, type: BetfairApiNgRails::Event
  attribute :market_count
end

By default type of attribute is String and not array.
Additionally it must has ability to mark attribute as array:

attribute :events, type: BetfairApiNgRails::Event, array: true

Every 20 minutes ssoid will be expired. But betfair provides keep-alive sessions. For more information go there.

have to hack around to get to the australian endpoint because it's no longer param driven.

Maybe event types are constants and it is good decision to add they to Constants module

Writing requests logs to log/betfair_api_ng_rails.{environment}.log.

They include:

1. listEventTypes
2. listCompetitions
3. listTimeRanges
4. listEvents
5. listMarketTypes
6. listCountries
7. listVenues

After architecture overview I noticed one very important mistake - ssoid request is done for every different API-NG requests. I think is will be good if ssoid will share between all requests.

For sample:

{"jsonrpc": "2.0", "method": "SportsAPING/v1.0/listMarketCatalogue", "params": {"filter":{"eventIds":["27164277"]},"maxResults":"100"}, "id": 1}

In this example additional params is maxResults.

Hi,

For some reason I'm getting syntax errors when trying to use the gem for the very first time. It's complaining about the betting.rb file. Should this be happening? It shows up after having run "bundle install" and then trying to run "bundle exec rake betfair_api_ng_rails:install"

betfair_api_ng_rails/lib/betfair_api_ng_rails/api/request_methods/betting.rb:15: syntax error, unexpected tLABEL, expecting ')'
...f list_market_catalogue(filter: BetfairApiNgRails::MarketFil...
... ^

Thanks!

Using gem about month in production I came to the conclusion that caching subsystem is very necessary because:

1. Data is enough longlife
2. Sometimes request's time reaches 20 second
3. Will be a lot of requests for same data and, of course, response also will be equal