Code Monkey home page Code Monkey logo

fast-react-render's People

Contributors

sigorilla avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

fast-react-render's Issues

Need licensing information

We need this! Can you please add licensing information to the readMe? Do you feel this is ready for use in production?

Cannot read property 'render' of undefined

After swapping up the stock renderer for fast-react-render, the following error popped up when trying to render the page:

(node:11472) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot read property 'render' of undefined

Should this library just work when swapping out the renderer or are there non-documented edge cases where it breaks?

elementToString with <Provider> return promise

This code:

import React, {Component} from 'react';
import {RouterContext} from 'react-router';
import {Provider} from 'react-redux';

ReactRender.elementToString(<Provider store={ store }>
                <RouterContext { ...this.props }/>
            </Provider>)

..returns a promise, instead of a html string.

What are the downsides/risks in comparison to traditional SSR?

Hi,

First of all, I'm very impressed with the results we got during the tests of the library. You did really a great job here!

But as we all know, such huge performance gains usually come at a cost, so I wonder, which kind of risks and limitations this SSR solution implies comparing to ReactDOMServer.renderToStaticMarkup?

I've also noticed in some of the issues, that you mentioned you're using it in production at Yandex, is it still the case?

Cheers

react + redux

А как можно подключить react-redux? Connect компонент жалуется на

{ Invariant Violation: Could not find "store" in either the context or props of "Connect(Component)". Either wrap the root component in a <Provider>, or explicitly pass "store" as a prop to "Connect(Component)".
    at invariant (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/invariant/invariant.js:42:15)
    at new Connect (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/react-redux/lib/components/connect.js:132:36)
    at renderComponent (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:97:20)
    at renderElement (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:43:20)
    at renderChildren (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:201:20)
    at renderNativeComponent (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:70:23)
    at renderElement (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:40:16)
    at renderComponent (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:127:16)
    at renderElement (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:43:20)
    at renderChildren (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:201:20)
    at renderNativeComponent (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:70:23)
    at renderElement (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:40:16)
    at renderElement (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:45:20)
    at renderElement (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:45:20)
    at renderComponent (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:127:16)
    at renderElement (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:43:20) name: 'Invariant Violation', framesToPop: 1 } Invariant Violation: Could not find "store" in either the context or props of "Connect(Component)". Either wrap the root component in a <Provider>, or explicitly pass "store" as a prop to "Connect(Component)".
    at invariant (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/invariant/invariant.js:42:15)
    at new Connect (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/react-redux/lib/components/connect.js:132:36)
    at renderComponent (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:97:20)
    at renderElement (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:43:20)
    at renderChildren (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:201:20)
    at renderNativeComponent (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:70:23)
    at renderElement (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:40:16)
    at renderComponent (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:127:16)
    at renderElement (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:43:20)
    at renderChildren (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:201:20)
    at renderNativeComponent (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:70:23)
    at renderElement (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:40:16)
    at renderElement (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:45:20)
    at renderElement (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:45:20)
    at renderComponent (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:127:16)
    at renderElement (/Users/nikolajmendaev/Projects/anews-frontend-3/node_modules/fast-react-render/src/index.js:43:20) Could not find "store" in either the context or props of "Connect(Component)". Either wrap the root component in a <Provider>, or explicitly pass "store" as a prop to "Connect(Component)".

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.