aloisdeniel / built_bloc Goto Github PK

@sink
@Bind('_handleColorModification')
final PublishSubject<Color> _changeColor = PublishSubject();  

Is generated to :

Sink<dynamic> get changeColor => this._parent._changeColor.sink;

final BehaviorSubject _test = BehaviorSubject<bool>(); is generate to Stream<dynamic> get msiEnabled => _parent._msiEnabled.stream;

final BehaviorSubject<bool> _test = BehaviorSubject(); works fine :)

Would be nice to have a changelog to know what have change between versions.

I generally don't expose raw Stream type, as we use RX it's more interesting to expose Observable for publishSubject, ValueObservable for behaviorSubject.

@bloc
class _GeneratedExampleBloc extends Bloc {
  @sink
  PublishSubject<int> get add => fromPublish(onData: this._onAdd);

  @stream
  BehaviorSubject<int> get count => fromBehavior(0);

  void _onAdd(int value) {
    this._count.add(this._count.value + 1);
  }
}

become something like:

@bloc
class GeneratedExampleBloc extends Bloc with _GeneratedExampleBloc {
  @sink
  PublishSubject<int> _add => fromPublish(onData: this._onAdd);

  @stream
  BehaviorSubject<int> _count = fromBehavior(0);

  void _onAdd(int value) {
    this._count.add(this._count.value + 1);
  }
}

The point is to write something you'll use directly on your classes instead of some private class, I think it will also have the possibility to have some code coverage to our class as private class and generated are generally ignored from code coverage. Having them public will be really useful.

In order to migrate to flutter v2 we will need a null safety support on this package, is there any plan about it ?

Thanks :D

Basically here is what's generated when using @Bind

@override
  void subscribeParent(LoginPhoneBloc value) {
    this._parent = value;
    this._parent._phoneNumber.listen(value._managePhoneNumber);
  }

Problem is that if later you're doing something like

_phoneNumber.addError('Wrong phone!!!');

You get a crash, but it's a wanted error that will be show on UI side, I don't want it to spread.

The right generated code should be:

this._parent._phoneNumber.listen(value._managePhoneNumber, onError: (_) {});

By default I think @Bind should swallow errors, as in bloc you mainly addError because you want it. but an additional ignoreError boolean field to override that behavior can be useful (maybe ^^)