Comments (4)
Ok, I'll rename SoundProps
to AudioSource
but I won't touch the other classes. I agree we should keep voice
separate (a subgroup?) of handles.
Thanks for looking into deinit()
!
from flutter_soloud.
Possibly SoundHandle
should be Voice
? Although even the C++ docs are inconsistent and call it mostly "sound handle".
from flutter_soloud.
cc @alnitak for you thoughts on this
from flutter_soloud.
Or maybe deinit() should be a synchronous "kill switch"
I just came across this situation with #54 ! :) So I also think your deinit()
"kill switch" is a good idea.
For example,
SoundProps
might becomeAudioSource
.
IIRC I named SoundProps
(SoundProperties shortened), to store the ways to manage it in native code.
Into SoundProps
we could add for example the audio file name, like in native, but also any other properties we like. It's not really like Soloud::AudioSource
which in SoundProps
could be represented by SoundHash
.
Anyway, I like AudioSource
name more than SoundProps
!
Possibly SoundHandle should be Voice? Although even the C++ docs are inconsistent and call it mostly "sound handle".
I recall that I get a bit confused too when I read voice
. Maybe it's a deeper Soloud lib concept needed maybe if/when we will go deeper integrating the lib into the plugin. The Soloud author says "The handle is an integer, and internally tracks the voice and sound id, as well as an "uniqueness" value.", so I think the "voice" could be thought as a sub-type of a handle.
from flutter_soloud.
Related Issues (20)
- feat: Find a better mechanism than the `audioEvent` stream for listening to changes in the engine HOT 3
- feat: Fail-fast more often HOT 2
- feat: WASM support HOT 27
- chore: Address C++ compilation warnings HOT 2
- feat: Implement setProtectVoice() HOT 1
- docs: What does disposeSound actually do? HOT 2
- fix: Wrong error reported when trying to add a filter twice
- bug: crash on deinit() HOT 1
- docs: Document that iOS app gives a warning to the user about microphone permission -- but only in debug mode and not in production HOT 22
- feat: Simplified Recording Mechanism HOT 12
- feat: WaveForm for complete Audiofile HOT 1
- perf: Ability to play precise sound sequences HOT 3
- fix: Missing audio on playing a loaded url HOT 1
- fix: Init error on hot restart HOT 3
- fix: handles become invalid at unknown points HOT 9
- MA_NODE_FLAG_SILENT_OUTPUT duplicates API recursive triggers (bangs) HOT 2
- feat: Set audio session mode to allow audio to mix with others
- refactor: get rid of AudioIsolate
- feat: Add functions to directly get and set pan
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flutter_soloud.