Code Monkey home page Code Monkey logo

Comments (4)

filiph avatar filiph commented on June 5, 2024 1

Ok, I'll rename SoundProps to AudioSource but I won't touch the other classes. I agree we should keep voice separate (a subgroup?) of handles.

Thanks for looking into deinit()!

from flutter_soloud.

filiph avatar filiph commented on June 5, 2024

Possibly SoundHandle should be Voice? Although even the C++ docs are inconsistent and call it mostly "sound handle".

from flutter_soloud.

filiph avatar filiph commented on June 5, 2024

cc @alnitak for you thoughts on this

from flutter_soloud.

alnitak avatar alnitak commented on June 5, 2024

Or maybe deinit() should be a synchronous "kill switch"

I just came across this situation with #54 ! :) So I also think your deinit() "kill switch" is a good idea.

For example, SoundProps might become AudioSource.

IIRC I named SoundProps (SoundProperties shortened), to store the ways to manage it in native code.
Into SoundProps we could add for example the audio file name, like in native, but also any other properties we like. It's not really like Soloud::AudioSource which in SoundProps could be represented by SoundHash.
Anyway, I like AudioSource name more than SoundProps!

Possibly SoundHandle should be Voice? Although even the C++ docs are inconsistent and call it mostly "sound handle".

I recall that I get a bit confused too when I read voice. Maybe it's a deeper Soloud lib concept needed maybe if/when we will go deeper integrating the lib into the plugin. The Soloud author says "The handle is an integer, and internally tracks the voice and sound id, as well as an "uniqueness" value.", so I think the "voice" could be thought as a sub-type of a handle.

from flutter_soloud.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.