birdseye is not fully closed upon exit of birdseye about birdseye-vscode HOT 6 CLOSED

It looks mostly fine. Some small points:

• You mention 'Karsimiov' but the linked blog says 'Krasimir'
• The title is not very descriptive, mention that you're killing a tree/family/group of processes
• The comment I made in 5280cd2

from birdseye-vscode.

https://stackoverflow.com/questions/33325301/killing-a-bash-script-does-not-kill-child-processes

This looks like it might work

from birdseye-vscode.

Nevermind - doesn't work for windows :/

Open a process with detached on windows causes the process to pop open with a console window.
Trying to kill with a negative pid results in Error: kill ESRCH

Apparently killing all children is not supported on windows :(

nodejs/node#3617

Or at least not with node - I could spin up a subprocess to nuke them in another language.

This guy did exactly that: http://krasimirtsonev.com/blog/article/Nodejs-managing-child-processes-starting-stopping-exec-spawn

from birdseye-vscode.

Confirmed fixed on windows :D

Still need to test on ubuntu

import {exec} from 'child_process'

/**
 * kills the process and all its children
 * If you are on linux process needs to be launched in detached state
 * @param pid process identifier
 * @param signal kill signal
 */
export function killAll(pid:number, signal:string|number='SIGKILL'){
    if(process.platform == "win32"){
        exec(`taskkill /PID ${pid} /T /F`, (error, stdout, stderr)=>{
            console.log("stdout: " + stdout)
            console.log("stdout: " + stderr)
            if(error){
                console.log("error: " + error.message)
            }
        })
    }
    else{
        // see https://nodejs.org/api/child_process.html#child_process_options_detached
        // If pid is less than -1, then sig is sent to every process in the process group whose ID is -pid.
        process.kill(-pid, signal)
    }
}

from birdseye-vscode.

Well forgot to test on ubuntu but I just tested on mac and it looks like it works

1. Launch birdseye

2. ps -ax | grep python

3. Two results

4. Close birdseye

5. ps -ax | grep python

6. no results.

@alexmojaki I published a medium article on how to kill processes with node - does the explanation make sense? Any thoughts?

https://medium.com/@almenon214/killing-processes-with-node-772ffdd19aad

from birdseye-vscode.

good catch. Fixed typo made in 5280cd2 and the gist. Updated the article to change the title and name.

https://medium.com/@almenon214/killing-processes-with-node-772ffdd19aad

from birdseye-vscode.