Comments (6)
Hi @therealadityashankar. I assume you mean using a sql database (postgres/mysql?) to store the rate limit data? I'm open to the idea but would love to hear some more details around your motivation.
from limits.
I mostly want to do it because I'm not completely pro the Idea of running a database engine (like sql, mongodb, ...) which is required for large amounts of data and redis parallelly,
The problem is more from a management point of view, also, I kinda don't really wanna set it up, (especially for smaller applications), when I can directly do it with SQL
I'd be using SQLAlchemy, so most SQL dialects should be supported,
I'd have to do some speed testing beforehand though, about how SQL compares to Redis, this article (in the operations section) shows how SQL compares to Redis, (spoiler: SQL is slower) before though to see if its even a good Idea
from limits.
@therealadityashankar I'm going to transfer this issue to the https://github.com/alisaifee/limits repository (since if it were to happen it would be implemented there, not here.
from limits.
(sorry if this comes of as rude in advance)
I kinda spent an hour digging through code all the way from https://limits.readthedocs.io/en/latest/custom-storage.html to the source code itself to attempt to write a custom storage implimentation
It'd be amazing in you could better document the code in limits.storage.Storage, as to give an explanation to exactly what each function is supposed to do.
I'm not exactly able to make sense on to how I can actually write my own implimentation
Sorry and Thanks in advance 😸
from limits.
Hi @therealadityashankar. Sorry for the delay in getting back to you on this. Are you still interested in this feature?
from limits.
no, not really, I think redis is a better option now compared to sql for this library
from limits.
Related Issues (20)
- ssl_cert_reqs="required" is not allowing me to connect to Redis HOT 2
- Question: Does In-Memory Storage clear itself when limit expires or it will keep getting bloated? HOT 1
- Add support for etcd HOT 5
- Flaky unit test(s): time window HOT 20
- Relax of packaging dependency did not take effect? HOT 3
- Hit incorrectly returns True when cost higher than limit HOT 4
- RedisCluster does not work with password in uri HOT 3
- Plans to add support for DynamoDB HOT 3
- `pkg_resources` is deprecated HOT 11
- Shared ratelimit across multiple instances HOT 2
- Exponential / growing limits HOT 2
- change coredis to redis-py HOT 1
- Issue with implementing limits in fastapi HOT 5
- Unable to create `MovingWindowRateLimiter` for Asynchronous Redis Sentinel storage HOT 2
- Support redis cluster like aws Elasti Cache HOT 2
- Unnecessary dependency on setuptools HOT 1
- Fixed window strategy using mongodb storage not working HOT 6
- Ability to 'undo' last hit on exception response HOT 2
- Extend WindowStats: add time left before reset HOT 2
- Bug: async RedisStorage does not accept `async+unix` URIs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from limits.