Code Monkey home page Code Monkey logo

Comments (6)

alisaifee avatar alisaifee commented on August 26, 2024

I don’t think I understand the issue clearly, could you provide a reproduction step?

from limits.

bertytobing avatar bertytobing commented on August 26, 2024

I don’t think I understand the issue clearly, could you provide a reproduction step?

  1. Use mongodb for storage.
  2. Adopt the fixed-window strategy.
  3. Set the rate limit to 2/1 minute.
  4. Hit the endpoint at 00:00:55 and again at 00:00:59.
  5. Hit the endpoint once more at 00:01:01. You'll receive a 429 error (indicating too many requests).

If I'm understanding correctly, the fixed-window strategy should reset the limit based on the specified period, in this case, every minute (at zero seconds). However, it currently seems to reset the limit based on the second of the first request (moving-window strategy).

from limits.

alisaifee avatar alisaifee commented on August 26, 2024

Yes this is the expected behavior of the fixed window strategy is implemented (regardless of the storage type) - i.e. the window is constructed based on the second of the first hit.

from limits.

bertytobing avatar bertytobing commented on August 26, 2024

Yes this is the expected behavior of the fixed window strategy is implemented (regardless of the storage type) - i.e. the window is constructed based on the second of the first hit.

So If I want to make it reset every month let's say, how to achieve that?

from limits.

alisaifee avatar alisaifee commented on August 26, 2024

So If I want to make it reset every month let's say, how to achieve that?

You could call the reset method on the storage if it supports it using a scheduled job

from limits.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.