alisabzevari / kotlin-http4k-realworld-example-app Goto Github PK

Swagger description:

Currently, handler classed does not contain the logic of the application. Instead, almost all the logic is implemented in ConduitRepository. I think after using exposed having a separate class to hold all queries don't make sense anymore. The better abstraction would be having a (mockable) class which holds the database connection and transaction function.

The application uses time in different parts of the code. For example, when creating article. In order to be able to properly test handlers Clock should be a dependency of the handler.

Currently, the token generation logic hard-codes the signing key and expiration. But these values should be configurable and provided by AppConfig. Signing key should be provided as an environment variable.

Swagger description:

Swagger description:

$ javac -version
javac 11.0.6

$ ./gradlew run
...
[INFO ] o.e.j.s.Server - Started @3084ms
[INFO ] main - Server started on port 9000

curl http://localhost:9000/
(nothing)

Used Chrome: No webpage was found for the web address: http://localhost:9000/
HTTP ERROR 404

Looked with netstat. A server is listening on 9000:
$ netstat -ant|grep 9000
TCP 0.0.0.0:9000 0.0.0.0:0 LISTENING InHost
TCP [::]:9000 [::]:0 LISTENING InHost
TCP [::1]:9000 [::1]:59033 TIME_WAIT InHost
TCP [::1]:9000 [::1]:59034 TIME_WAIT InHost

There is only one class containing all the routes and their handlers. Having separated route handlers categorized by top-level endpoint name (e.g. tags, profiles etc) makes sense.

Swagger description:

Swagger description:

Suggested test cases:

• Should throw proper exception when article not found.
• Should call insertComment of repository with proper values.
• Should return the created comment

Swagger description:

Suggested test cases:

• The user should be able to only delete comment created by themselves.
• It should call deleteArticleComment from repository.

After upgrading to Kotlin 1.3 it is possible to use inline classes for opaque types.

Swagger docs:

http4k is so nicely designed and it helps to write integration tests much easier. One idea could be to remove some of the unit tests (or replace unit tests with some general non-related-to-business tests) and test the whole business of the application based on the postman test file using integration tests.

Swagger description:

Suggested test cases:

• It should throw exception if the article does not belong to the current user.
• It should call deleteArticle from repository.
• it should throw exception when the article doesn't exist.

Swagger description:

Suggested test cases:

• It should throw proper exception when article does not exist.
• If the user has not been favorited the article before, the handler should not throw exceptions.
• It should throw exception when the article author not found.
• It should return proper values for the return object.

Suggested test cases:

• Article slug should properly being generated from title.
• It should call insertArticle from repository.
• It should return the created article with proper initial values.

Swagger description:

Swagger description:

Suggested test cases:

• Should throw proper exception when article not found.
• If it is not a favorited article, it should call insertFavorite of repository.
• Should throw proper exception when article doesn't have an author.
• The favoritesCount in the return value object should has been increased by one.

Suggested test cases:

• Article slug should properly being generated from title.
• It should call insertArticle from repository.
• It should return the created article with proper initial values.

Swagger description:

Swagger description:

model related classes are scattered everywhere in the project. They should belong to the right package and right place.

https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/test/publish-code-coverage-results?view=azure-devops

https://kevcodez.de/index.php/2018/08/test-coverage-in-kotlin-with-jacoco/