Code Monkey home page Code Monkey logo

Comments (2)

mpre avatar mpre commented on June 25, 2024

Hi @ivargr, thanks for your comments, we are glad you're testing our tool.

Both requests are sensible but unfortunately they are not part of the current version of malva.

The first point might need some major rework and it's not to be expected in the foreseeable future.

Regarding the second point, I just pushed a new branch to this repository that tries to solve it (branch split_main). Using that branch you can now use malva-geno index to create the index of your reference genome/vcf and then malva-geno call to produce the output vcf that includes the genotypes. You still need to pass all the arguments to both steps since I didn't rework the interface yet (arguments that don't affect the index/call step will simply be ignored). If you use the MALVA script it will also check if the index is available already and, if so, skip the indexing step.

This version is not published on bioconda yet and it will probably take a while before we will be able to clean up the code and push it to bioconda, so you'll need to compile it yourself and take care of the dependecies.

Finally, I want to stress that this version is experimental, I tested it on the example we provide in the repo and it works but I didn't check `whether there's some performance hit on big datasets or if it breaks in some edge cases. The index might also not be portable since it's basically a serialization of the in-memory index.

from malva.

ivargr avatar ivargr commented on June 25, 2024

Thanks a lot for the quick response!

I've tested the new branch and it seems to work great on the data I have tried it with!

No worries about Malva not being able to multithread fully for now, I was mostly just curious on whether was possible or not, but it would be a cool potential improvement in a future version of Malva :)

from malva.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.