Issues with Dockerfile about galig HOT 6 CLOSED

Dear Luca,

I've made some very minor changes to your dockerfile.

1. I commented out lines 44 and 45 which tries to download and verify gpg keys, cause that killed the docker build command for me.
2. I added a line after line 60: ENV PATH $PATH:/galig/asgal
   just to have asgal show up without the full path, but as just another command in this environment.

And otherwise, your Dockerfile is pretty much PERFECT. I tested it out and I have zero complains.

Thank you for all your support, Luca.
You have been incredibly helpful and supportive throughout this entire process. I really respect that.

Cheers,
Amit

from galig.

Dear @amitfenn
Let us try to fix this dockerfile once and for all.
I have created a new branch (https://github.com/AlgoLab/galig/tree/issue-%237) with a docker directory.
Please clone the repo, switch to the issue-#7 branch, go to the docker dir and issue the follwing commands:

docker build -t algolab/asgal:v1.1.1 .
cd ../example
tar xvzf input.tar.gz
docker run  -v $(pwd)/input:/data algolab/asgal:v1.1.1

On my computer, it works™️ ;-)
Thanks for your understanding

from galig.

Hi Again, Luca.

Thanks for maintaining ASGAL. I noticed your dockerfile doesn't build anymore. I get the following error message at line: 38 of your Dockerfile

* CXX /galig/src/utils.cpp
cc1plus: error: bad value ('tigerlake') for '-march=' switch
cc1plus: note: valid arguments to '-march=' switch are: nocona core2 nehalem corei7 westmere sandybridge corei7-avx ivybridge core-avx-i haswell core-avx2 broadwell skylake skylake-avx512 cannonlake icelake-client icelake-server cascadelake bonnell atom silvermont slm goldmont goldmont-plus tremont knl knm x86-64 eden-x2 nano nano-1000 nano-2000 nano-3000 nano-x2 eden-x4 nano-x4 k8 k8-sse3 opteron opteron-sse3 athlon64 athlon64-sse3 athlon-fx amdfam10 barcelona bdver1 bdver2 bdver3 bdver4 znver1 znver2 btver1 btver2 native
cc1plus: error: bad value ('tigerlake') for '-mtune=' switch
cc1plus: note: valid arguments to '-mtune=' switch are: nocona core2 nehalem corei7 westmere sandybridge corei7-avx ivybridge core-avx-i haswell core-avx2 broadwell skylake skylake-avx512 cannonlake icelake-client icelake-server cascadelake bonnell atom silvermont slm goldmont goldmont-plus tremont knl knm intel x86-64 eden-x2 nano nano-1000 nano-2000 nano-3000 nano-x2 eden-x4 nano-x4 k8 k8-sse3 opteron opteron-sse3 athlon64 athlon64-sse3 athlon-fx amdfam10 barcelona bdver1 bdver2 bdver3 bdver4 znver1 znver2 btver1 btver2 generic native
make[1]: *** [/galig/Makefile:150: utils.o] Error 1
make: *** [target.mk:17: /galig/obj] Error 2
The command '/bin/sh -c cd galig ; make' returned a non-zero code: 2

Could you please take a second look at the Dockerfile for me?
Thanking you,
Amit.

from galig.

Dear @amitfenn
Can you confirm that you have tried to build ASGAL on a Tigerlake cpu?

from galig.

Dear Luca,
I was on a Tigerlake cpu. But if this is the problem, please don't spend too much time on this. Asgal Dockerfile works almost perfectly on my server, I just tried it out.

I had to modify "FROM ubuntu:20.04" to "FROM ubuntu:20.10", as some of the apt packages where no longer being shipped for 20.04.

Thanks for your time and your quick response. It is very much appreciated.
Amit.

from galig.

I suspect that the gcc version shipped with ubuntu 20.04 does not support the newest CPUs.
The docker image (i.e. the one you get with a docker pull) should work on Tigerlake too.

I am leaving this open as a reminder to update the base image to 22.04 once it has been released.

Take care

from galig.