Code Monkey home page Code Monkey logo

parallel-card-bot's People

Stargazers

 avatar

Watchers

 avatar  avatar  avatar

parallel-card-bot's Issues

Card JSON data needs a URL override

Some URLs are in the new hyphenated-words format like Antius's Forecast, others are old numerical such as Trigger-Happy Trooper. We can only auto-generate the new format with any accuracy, so we will have to leverage site-scraping data (or get Parallel to provide us with a regular data set) to have accurate links for all cards.

The data itself is somewhat of a moving target -- Parallel may choose to 'rug pull' the old URLs and replace them with new ones at any time, so the best we can do (apart from getting them to generate the JSON for us...) is to add an override URL to our JSON data for each card.

Then, we adjust our algorithm to check for a URL on the card data. If there is one present, we prefer it. If it is absent, we generate it from the name and hope for the best.

Feature request: credits

! credits: Lazer wrote this all himself with no help whatsoever, especially not that lazybones @JERisBRISK // Lord of Cables (yes, have it @ him every time)

site command does not trim punctuation, so generated links are incorrect.

The current logic hyphenates card names to convert them to parallel URLs. E.g.:

!site "Archivist's Pride"
https://parallel.life/cards/archivist’s-pride

However, the URL is incorrect and results in a 404. It should be:
https://parallel.life/cards/archivists-pride/

Another example is Soleia:

!site "soleia, disciple of gaffar"
https://parallel.life/cards/soleia,-disciple-of-gaffar

URL should actually be:
https://parallel.life/cards/soleia-disciple-of-gaffar/

Another example is GRAUL

!site "G.R.A.U.L." (note, the trailing period is incorrect, issue #5 addresses that)
https://parallel.life/cards/g.r.a.u.l.

URL should actually be:
https://parallel.life/cards/graul

emoji aren't rendering correctly

we tried acting like a human and using :color_earthen: but it's not showing properly.

image

Let's try these instead:

<:color_earthen:850233295371632670>
<:color_kathari:850233295362850816>
<:color_marcolian:850233295501262899>
<:color_shroud:850233295501000704>
<:color_augencore:850233294971994123>

Investigation: channel filters

We may want to restrict some commands to a certain channel or set of channels by name. Other commands we may want usable everywhere (e.g., !disclaimer). See if discord.py supports this (either by providing the channel name to us, allow us to inspect it, or possibly implementing such filters on commands themselves)

G.R.A.U.L data is incorrect

Current name is

"Card Name": "G.R.A.U.L.",

Should not have the trailing period:

"Card Name": "G.R.A.U.L",

Feature request: multiple words without quotes

A rather obtuse requirement of the bot has been to surround multiple words with quotes. This leads to strange scenarios like:

image

Where the wrong thing is returned without quotes, and the right thing is returned with quotes, the only difference being the quotes. This is due to the second word being ignored completely (only "life" is passed in).

The user really shouldn't have to use quotes. around the names when all of the arguments are part of the query, and there are no other parameters.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.